From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
rteysseyre@gmail.com, bjorn.andersson@linaro.org,
broonie@kernel.org, linus.walleij@linaro.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger
Date: Wed, 24 Oct 2018 10:31:43 +0200 [thread overview]
Message-ID: <20181024083143.GA24165@amd> (raw)
In-Reply-To: <d90397dd-429f-4f3f-307c-b69dccc360e0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]
Hi!
> > +
> > + The gradual dimming format of the software pattern values should be:
> > + "brightness_1 duration_1 brightness_2 duration_2 brightness_3
> > + duration_3 ...". For example:
> > +
> > + echo 0 1000 255 2000 > pattern
> > +
> > + It will make the LED go gradually from zero-intensity to max (255)
> > + intensity in 1000 milliseconds, then back to zero intensity in 2000
> > + milliseconds:
> > +
> > + LED brightness
> > + ^
> > + 255-| / \ / \ /
> > + | / \ / \ /
> > + | / \ / \ /
> > + | / \ / \ /
> > + 0-| / \/ \/
> > + +---0----1----2----3----4----5----6------------> time (s)
> > +
Ok, so I got around to testing this.
echo "0 1000 10 2550 0 1000 0 100" > pattern
makes expected pattern [ .-xXx-. ].
But when I do
echo "0 1000 10 2550 0 1000" > pattern
I only get expected pattern on the first iteration, then I get
[ Xx-. ].
I'm using led-controller:flash on nokia n900 (so everything in
software).
> OK, let's abide by constant update interval for now.
>
> Thank you for your work on this patch set throughout
> all these months. We will have -rc8, so one week of testing
> before sending upstream should be enough.
>
> Patch set applied to the for-next branch of linux-leds.git.
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-10-24 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 4:07 Baolin Wang
2018-10-11 4:07 ` [PATCH v15 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Baolin Wang
2018-10-11 20:07 ` [PATCH v15 1/2] leds: core: Introduce LED pattern trigger Jacek Anaszewski
2018-10-12 1:40 ` Baolin Wang
2018-10-24 8:34 ` Pavel Machek
2018-10-24 8:31 ` Pavel Machek [this message]
2018-10-24 19:17 ` Jacek Anaszewski
2018-10-24 19:55 ` Pavel Machek
2018-10-24 20:44 ` [PATCH] Fix pattern handling optimalization Pavel Machek
2018-10-25 19:17 ` Jacek Anaszewski
2018-10-25 21:24 ` More checks for patterns? was: " Pavel Machek
2018-10-26 8:02 ` Baolin Wang
2018-10-26 19:56 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024083143.GA24165@amd \
--to=pavel@ucw.cz \
--cc=baolin.wang@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rteysseyre@gmail.com \
--subject='Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).