From: Ivan Khoronzhuk <email@example.com> To: firstname.lastname@example.org, email@example.com Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [RFC PATCH net-next 3/4] net: ethernet: ti: cpsw: fix vlan mcast Date: Wed, 24 Oct 2018 14:36:10 +0300 [thread overview] Message-ID: <20181024113609.GC4892@khorivan> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, Oct 16, 2018 at 09:20:34PM +0300, Ivan Khoronzhuk wrote: >At this moment, mcast addresses are added only for real device only >(reserved vlans for dual-emac mode), even if a mcast address was added >for some vlan only, thus ALE doesn't have corresponding vlan mcast >entries after vlan socket joined multicast group. So ALE drops vlan >frames with mcast addresses intended for vlans and potentially can >receive mcast frames for base ndev. That's not correct. So, fix it by >creating only vlan/mcast entries as requested. Patch doesn't use any >additional lists and is based on device mc address list and cpsw ALE >table entries. > >Also, move device to allmulti state if no space for new mcast entries. > >Signed-off-by: Ivan Khoronzhuk <email@example.com> I won't update allmulti state on v2, will do that separately as it requires also splitting allmulti between interfaces in dual-mac mode. Would be nice to move allmulti and promisc to ndo_change_rx_flags() and do updates only if flag is changed, not for every address change. Also there is an ability to set allmulti per vlan device and even dev->allmulti counter can be used for that and it works, but in case of allmulti flag there is no event from dev core if it's already set (only allmuilti counter is changed w/o event). Thus no event to segregate it between vlans. Adding update to dev core can lead to more frequent rx_mode event and w/o reason for those devices who doesn't care. I'm just wondering, why not to add smth like IFF_VLAN_MCAST_FLT to dev->priv_flags and based on it generate event differently or even do more stuff .... Or leave it as is and set allmulti for every vlan, that seems like a stub. [...] -- Regards, Ivan Khoronzhuk
next prev parent reply other threads:[~2018-10-24 11:36 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-16 18:20 [RFC PATCH net-next 0/4] " Ivan Khoronzhuk 2018-10-16 18:20 ` [RFC PATCH net-next 1/4] net: core: dev_addr_lists: add auxiliary func to handle reference address updates Ivan Khoronzhuk 2018-10-16 18:20 ` [RFC PATCH net-next 2/4] net: 8021q: vlan_core: allow use list of vlans for real device Ivan Khoronzhuk 2018-10-16 19:39 ` Grygorii Strashko 2018-10-16 20:15 ` David Miller 2018-10-19 11:22 ` Bjørn Mork 2018-10-19 14:02 ` Ivan Khoronzhuk 2018-10-16 18:20 ` [RFC PATCH net-next 3/4] net: ethernet: ti: cpsw: fix vlan mcast Ivan Khoronzhuk 2018-10-24 11:36 ` Ivan Khoronzhuk [this message] 2018-10-16 18:20 ` [RFC PATCH net-next 4/4] net: ethernet: ti: cpsw: fix vlan configuration while down/up Ivan Khoronzhuk 2018-10-16 19:38 ` [RFC PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast Grygorii Strashko 2018-10-17 20:11 ` Ivan Khoronzhuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181024113609.GC4892@khorivan \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC PATCH net-next 3/4] net: ethernet: ti: cpsw: fix vlan mcast' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).