From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6567AECDE47 for ; Thu, 25 Oct 2018 07:29:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35367205F4 for ; Thu, 25 Oct 2018 07:29:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35367205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gentoo.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbeJYQAv (ORCPT ); Thu, 25 Oct 2018 12:00:51 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:35784 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbeJYQAv (ORCPT ); Thu, 25 Oct 2018 12:00:51 -0400 Received: from localhost (unknown [116.247.178.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id EFF23335CCC; Thu, 25 Oct 2018 07:29:19 +0000 (UTC) Date: Thu, 25 Oct 2018 15:29:15 +0800 From: Yixun Lan To: Jerome Brunet Cc: Jianxin Pan , Neil Armstrong , Rob Herring , Hanjie Lin , Victor Wan , Stephen Boyd , Kevin Hilman , Michael Turquette , Yixun Lan , linux-kernel@vger.kernel.org, Boris Brezillon , Liang Yang , Jian Hu , Miquel Raynal , Carlo Caione , linux-amlogic@lists.infradead.org, Martin Blumenstingl , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Qiufang Dai Subject: Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller Message-ID: <20181024145513.GA6647@ofant> References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-3-git-send-email-jianxin.pan@amlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerome, Jianxin: see my comments On 10:58 Wed 24 Oct , Jerome Brunet wrote: > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > > From: Yixun Lan > > > > Document the MMC sub clock controller driver, the potential consumer > > of this driver is MMC or NAND. Also add four clock bindings IDs which > > provided by this driver. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Yixun Lan > > Signed-off-by: Jianxin Pan > > --- > > .../devicetree/bindings/clock/amlogic,mmc-clkc.txt | 31 ++++++++++++++++++++++ > > include/dt-bindings/clock/amlogic,mmc-clkc.h | 17 ++++++++++++ > > 2 files changed, 48 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > > create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h > > > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > > new file mode 100644 > > index 0000000..9e6d343 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > > @@ -0,0 +1,31 @@ > > +* Amlogic MMC Sub Clock Controller Driver > > + > > +The Amlogic MMC clock controller generates and supplies clock to support > > +MMC and NAND controller > > + > > +Required Properties: > > + > > +- compatible: should be: > > + "amlogic,gx-mmc-clkc" > > + "amlogic,axg-mmc-clkc" > > + > > +- #clock-cells: should be 1. > > +- clocks: phandles to clocks corresponding to the clock-names property > > +- clock-names: list of parent clock names > > + - "clkin0", "clkin1" > > + > > +Parent node should have the following properties : > > +- compatible: "amlogic,axg-mmc-clkc", "syscon". > > +- reg: base address and size of the MMC control register space. > > I get why Stephen is confused by your description, I am too. The example > contradict the documentation. > > The documentation above says that the parent node should be a syscon with the > mmc register space. > > But your example shows this in the node itself. > yes, I think the documentation need to be fixed for the final solution, we decide to make 'mmc-clkc' an independent node instead of being a sub-node of 'mmc', so both of them may exist in parallel.. the DT part may like this: sd_emmc_c_clkc: clock-controller@7000 { compatible = "amlogic,axg-mmc-clkc", "syscon"; reg = <0x0 0x7000 0x0 0x4>; ... }; sd_emmc_c: mmc@7000 { compatible = "amlogic,axg-mmc"; reg = <0x0 0x7000 0x0 0x800>; ... }; > > + > > +Example: Clock controller node: > > + > > +sd_mmc_c_clkc: clock-controller@7000 { > > + compatible = "amlogic,axg-mmc-clkc", "syscon"; > > + reg = <0x0 0x7000 0x0 0x4>; > > + #clock-cells = <1>; > > + > > + clock-names = "clkin0", "clkin1"; > > + clocks = <&clkc CLKID_SD_MMC_C_CLK0>, > > + <&clkc CLKID_FCLK_DIV2>; > > +}; > > diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h b/include/dt-bindings/clock/amlogic,mmc-clkc.h > > new file mode 100644 > > index 0000000..162b949 > > --- /dev/null > > +++ b/include/dt-bindings/clock/amlogic,mmc-clkc.h > > @@ -0,0 +1,17 @@ > > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > > +/* > > + * Meson MMC sub clock tree IDs > > + * > > + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. > > + * Author: Yixun Lan > > + */ > > + > > +#ifndef __MMC_CLKC_H > > +#define __MMC_CLKC_H > > + > > +#define CLKID_MMC_DIV 1 > > +#define CLKID_MMC_PHASE_CORE 2 > > +#define CLKID_MMC_PHASE_TX 3 > > +#define CLKID_MMC_PHASE_RX 4 > > + > > +#endif > > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55