From: Andrew Morton <akpm@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Andrea Argangeli <andrea@kernel.org>,
Zi Yan <zi.yan@cs.rutgers.edu>,
Stefan Priebe - Profihost AG <s.priebe@profihost.ag>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask
Date: Wed, 24 Oct 2018 16:17:54 -0700 [thread overview]
Message-ID: <20181024161754.0d174e7c22113f4f8aad1940@linux-foundation.org> (raw)
In-Reply-To: <583b20e5-4925-e175-1533-5c2d2bab9192@suse.cz>
On Mon, 22 Oct 2018 15:27:54 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
> > : Moreover the oriinal code allowed to trigger
> > : WARN_ON_ONCE(policy->mode == MPOL_BIND && (gfp & __GFP_THISNODE));
> > : in policy_node if the requested node (e.g. cpu local one) was outside of
> > : the mbind nodemask. This is not possible now. We haven't heard about any
> > : such warning yet so it is unlikely that it happens but still a signal of
> > : a wrong code layering.
>
> Ah, as I said in the other mail, I think it's inaccurate, the warning
> was not possible to hit.
>
> There's also a slight difference wrt MPOL_BIND. The previous code would
> avoid using __GFP_THISNODE if the local node was outside of
> policy_nodemask(). After your patch __GFP_THISNODE is avoided for all
> MPOL_BIND policies. So there's a difference that if local node is
> actually allowed by the bind policy's nodemask, previously
> __GFP_THISNODE would be added, but now it won't be. I don't think it
> matters that much though, but maybe the changelog could say that
> (instead of the inaccurate note about warning). Note the other policy
> where nodemask is relevant is MPOL_INTERLEAVE, and that's unchanged by
> this patch.
So the above could go into the changelog, yes?
> When that's addressed, you can add
What is it that you'd like to see addressed? Purely changelog updates?
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
Thanks.
next prev parent reply other threads:[~2018-10-24 23:17 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 12:03 [PATCH 0/2] thp nodereclaim fixes Michal Hocko
2018-09-25 12:03 ` [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings Michal Hocko
2018-09-25 12:20 ` Mel Gorman
2018-09-25 12:30 ` Michal Hocko
2018-10-04 20:16 ` David Rientjes
2018-10-04 21:10 ` Andrea Arcangeli
2018-10-04 23:05 ` David Rientjes
2018-10-06 3:19 ` Andrea Arcangeli
2018-10-05 7:38 ` Mel Gorman
2018-10-05 20:35 ` David Rientjes
2018-10-05 23:21 ` Andrea Arcangeli
2018-10-08 20:41 ` David Rientjes
2018-10-09 9:48 ` Mel Gorman
2018-10-09 12:27 ` Michal Hocko
2018-10-09 13:00 ` Mel Gorman
2018-10-09 14:25 ` Michal Hocko
2018-10-09 15:16 ` Mel Gorman
2018-10-09 23:03 ` Andrea Arcangeli
2018-10-10 21:19 ` David Rientjes
2018-10-15 22:30 ` David Rientjes
2018-10-15 22:44 ` Andrew Morton
2018-10-15 23:19 ` Andrea Arcangeli
2018-10-22 20:54 ` David Rientjes
2018-10-16 7:46 ` Mel Gorman
2018-10-16 22:37 ` Andrew Morton
2018-10-16 23:11 ` Andrea Arcangeli
2018-10-16 23:16 ` Andrew Morton
2018-10-17 7:08 ` Michal Hocko
2018-10-17 9:00 ` Mel Gorman
2018-10-22 21:04 ` David Rientjes
2018-10-23 1:27 ` Zi Yan
2018-10-28 21:45 ` David Rientjes
2018-10-23 7:57 ` Mel Gorman
2018-10-23 8:38 ` Mel Gorman
2018-10-15 22:57 ` Andrea Arcangeli
2018-10-22 20:45 ` David Rientjes
2018-10-09 22:17 ` David Rientjes
2018-10-09 22:51 ` Andrea Arcangeli
2018-10-10 7:54 ` Vlastimil Babka
2018-10-10 21:00 ` David Rientjes
2018-10-09 13:08 ` Vlastimil Babka
2018-10-09 22:21 ` Andrea Arcangeli
2018-10-29 5:17 ` Balbir Singh
2018-10-29 9:00 ` Michal Hocko
2018-10-29 9:42 ` Balbir Singh
2018-10-29 10:08 ` Michal Hocko
2018-10-29 10:56 ` Andrea Arcangeli
2018-09-25 12:03 ` [PATCH 2/2] mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask Michal Hocko
2018-09-26 13:30 ` Kirill A. Shutemov
2018-09-26 14:17 ` Michal Hocko
2018-09-26 14:22 ` Michal Hocko
2018-10-19 2:11 ` Andrew Morton
2018-10-19 8:06 ` Michal Hocko
2018-10-22 13:27 ` Vlastimil Babka
2018-10-24 23:17 ` Andrew Morton [this message]
2018-10-25 4:56 ` Vlastimil Babka
2018-10-25 16:14 ` Michal Hocko
2018-10-25 16:18 ` Andrew Morton
2018-10-25 16:45 ` Michal Hocko
2018-10-22 13:15 ` Vlastimil Babka
2018-10-22 13:30 ` Michal Hocko
2018-10-22 13:35 ` Vlastimil Babka
2018-10-22 13:46 ` Michal Hocko
2018-10-22 13:53 ` Vlastimil Babka
2018-10-04 20:17 ` David Rientjes
2018-10-04 21:49 ` Zi Yan
2018-10-09 12:36 ` Michal Hocko
2018-09-26 13:08 ` linux-mm@ archive on lore.kernel.org (Was: [PATCH 0/2] thp nodereclaim fixes) Kirill A. Shutemov
2018-09-26 13:14 ` Michal Hocko
2018-09-26 22:22 ` Andrew Morton
2018-09-26 23:08 ` Mel Gorman
2018-09-27 0:47 ` Konstantin Ryabitsev
2018-09-26 15:25 ` Konstantin Ryabitsev
2018-09-27 11:30 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024161754.0d174e7c22113f4f8aad1940@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrea@kernel.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=s.priebe@profihost.ag \
--cc=vbabka@suse.cz \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).