From: "Máté Eckl" <ecklm94@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: bridge: define INT_MIN & INT_MAX in userspace
Date: Wed, 24 Oct 2018 21:17:45 +0200 [thread overview]
Message-ID: <20181024191745.jboas22he7ot7utd@sch.bme.hu> (raw)
In-Reply-To: <20181024115403.3938-1-jslaby@suse.cz>
On Wed, Oct 24, 2018 at 01:54:03PM +0200, Jiri Slaby wrote:
> With 4.19, programs like ebtables fail to build when they include
> "linux/netfilter_bridge.h". It is caused by commit 94276fa8a2a4 which
> added a use of INT_MIN and INT_MAX to the header:
> : In file included from /usr/include/linux/netfilter_bridge/ebtables.h:18,
> : from include/ebtables_u.h:28,
> : from communication.c:23:
> : /usr/include/linux/netfilter_bridge.h:30:20: error: 'INT_MIN' undeclared here (not in a function)
> : NF_BR_PRI_FIRST = INT_MIN,
> : ^~~~~~~
>
> Define these constants by including "limits.h" when !__KERNEL__ (the
> same way as for other netfilter_* headers).
Indeed I didn't think of this solution.
Thanks for the fix Jiri!
>
> Fixes: 94276fa8a2a4 ("netfilter: bridge: Expose nf_tables bridge hook priorities through uapi")
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Máté Eckl <ecklm94@gmail.com>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Máté Eckl <ecklm94@gmail.com>
> ---
> include/uapi/linux/netfilter_bridge.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/netfilter_bridge.h b/include/uapi/linux/netfilter_bridge.h
> index 156ccd089df1..1610fdbab98d 100644
> --- a/include/uapi/linux/netfilter_bridge.h
> +++ b/include/uapi/linux/netfilter_bridge.h
> @@ -11,6 +11,10 @@
> #include <linux/if_vlan.h>
> #include <linux/if_pppox.h>
>
> +#ifndef __KERNEL__
> +#include <limits.h> /* for INT_MIN, INT_MAX */
> +#endif
> +
> /* Bridge Hooks */
> /* After promisc drops, checksum checks. */
> #define NF_BR_PRE_ROUTING 0
> --
> 2.19.1
>
next prev parent reply other threads:[~2018-10-24 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 11:54 [PATCH] netfilter: bridge: define INT_MIN & INT_MAX in userspace Jiri Slaby
2018-10-24 19:17 ` Máté Eckl [this message]
2018-10-25 8:25 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024191745.jboas22he7ot7utd@sch.bme.hu \
--to=ecklm94@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=jslaby@suse.cz \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).