From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423DCC46475 for ; Thu, 25 Oct 2018 06:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D35752083E for ; Thu, 25 Oct 2018 06:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D35752083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=de.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbeJYO7Z (ORCPT ); Thu, 25 Oct 2018 10:59:25 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43064 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727185AbeJYO7Z (ORCPT ); Thu, 25 Oct 2018 10:59:25 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w9P6Pnpu049160 for ; Thu, 25 Oct 2018 02:28:06 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2nb8j8g2t2-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 25 Oct 2018 02:28:06 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Oct 2018 07:28:04 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 25 Oct 2018 07:28:02 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w9P6S1Oj65994932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Oct 2018 06:28:01 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CD7A4C044; Thu, 25 Oct 2018 06:28:01 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64E8E4C046; Thu, 25 Oct 2018 06:28:01 +0000 (GMT) Received: from osiris (unknown [9.152.212.171]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 25 Oct 2018 06:28:01 +0000 (GMT) Date: Thu, 25 Oct 2018 08:28:00 +0200 From: Heiko Carstens To: Sergey Senozhatsky Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , Peter Oberparleiter Subject: Re: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks() References: <20181024043048.21248-1-sergey.senozhatsky@gmail.com> <20181024043425.GA8862@jagdpanzerIV> MIME-Version: 1.0 In-Reply-To: <20181024043425.GA8862@jagdpanzerIV> X-TM-AS-GCONF: 00 x-cbid: 18102506-0008-0000-0000-000002854C2F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18102506-0009-0000-0000-000021EF4E6F Message-Id: <20181025062800.GB4037@osiris> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-25_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810250059 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2018 at 01:34:25PM +0900, Sergey Senozhatsky wrote: > On (10/24/18 13:30), Sergey Senozhatsky wrote: > From: Sergey Senozhatsky > Subject: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks() ... > From the comment it seems that s390 wants to just poke klogd. > There is wake_up_klogd() for this purpose, so we can replace > that printk(" "). > > Signed-off-by: Sergey Senozhatsky > --- > arch/s390/mm/fault.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c > index 2b8f32f56e0c..53915c61ad95 100644 > --- a/arch/s390/mm/fault.c > +++ b/arch/s390/mm/fault.c > @@ -92,16 +92,12 @@ void bust_spinlocks(int yes) > oops_in_progress = 1; > } else { > int loglevel_save = console_loglevel; > - console_unblank(); > - oops_in_progress = 0; > - /* > - * OK, the message is on the console. Now we call printk() > - * without oops_in_progress set so that printk will give klogd > - * a poke. Hold onto your hats... > - */ > + > console_loglevel = 15; > - printk(" "); > + console_unblank(); > console_loglevel = loglevel_save; > + oops_in_progress = 0; > + wake_up_klogd(); > } With your patch this looks nearly like the common code variant. I did some code archaeology and this function is unchanged since ~17 years. When it was introduced it was close to identical to the x86 variant. All other architectures use the common code variant in the meantime. So if we change this I'd prefer that we switch s390 to the common code variant as well. Right now I can't see a reason for not doing that, but I might be wrong of course. So, could you please provide a new version which just removes this variant and makes s390 use the generic one too. We'll see if there is any fallout...