linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
	punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com,
	steve.capper@arm.com, catalin.marinas@arm.com,
	akpm@linux-foundation.org, mike.kravetz@oracle.com,
	n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH V3 3/5] mm/hugetlb: Enable arch specific huge page size support for migration
Date: Thu, 25 Oct 2018 09:45:32 +0200	[thread overview]
Message-ID: <20181025074532.GM18839@dhcp22.suse.cz> (raw)
In-Reply-To: <bf5e636c-9cc4-50d6-4160-78a1a7703860@arm.com>

On Thu 25-10-18 11:53:34, Anshuman Khandual wrote:
> 
> 
> On 10/24/2018 07:28 PM, Michal Hocko wrote:
> > On Wed 24-10-18 15:56:39, Michal Hocko wrote:
> >> On Tue 23-10-18 18:31:59, Anshuman Khandual wrote:
> >>> Architectures like arm64 have HugeTLB page sizes which are different than
> >>> generic sizes at PMD, PUD, PGD level and implemented via contiguous bits.
> >>> At present these special size HugeTLB pages cannot be identified through
> >>> macros like (PMD|PUD|PGDIR)_SHIFT and hence chosen not be migrated.
> >>>
> >>> Enabling migration support for these special HugeTLB page sizes along with
> >>> the generic ones (PMD|PUD|PGD) would require identifying all of them on a
> >>> given platform. A platform specific hook can precisely enumerate all huge
> >>> page sizes supported for migration. Instead of comparing against standard
> >>> huge page orders let hugetlb_migration_support() function call a platform
> >>> hook arch_hugetlb_migration_support(). Default definition for the platform
> >>> hook maintains existing semantics which checks standard huge page order.
> >>> But an architecture can choose to override the default and provide support
> >>> for a comprehensive set of huge page sizes.
> >>>
> >>> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> >>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> >>
> >> Acked-by: Michal Hocko <mhocko@use.com>
> > 
> > fat fingers here, should be mhocko@suse.com of course.
> 
> Sure no problems. As we had discussed earlier and agreed to keep the previous
> patch "mm/hugetlb: Enable PUD level huge page migration" separate and not fold
> into this one, I will assume your ACK on it as well unless your disagree.

OK with me.

-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2018-10-25  7:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 13:01 [PATCH V3 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-23 13:01 ` [PATCH V3 1/5] mm/hugetlb: Distinguish between migratability and movability Anshuman Khandual
2018-10-24 13:54   ` Michal Hocko
2018-11-08 10:33   ` Steve Capper
2018-10-23 13:01 ` [PATCH V3 2/5] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual
2018-11-08 10:34   ` Steve Capper
2018-10-23 13:01 ` [PATCH V3 3/5] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual
2018-10-24 13:56   ` Michal Hocko
2018-10-24 13:58     ` Michal Hocko
2018-10-25  6:23       ` Anshuman Khandual
2018-10-25  7:45         ` Michal Hocko [this message]
2018-11-08 10:35   ` Steve Capper
2018-10-23 13:02 ` [PATCH V3 4/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-11-08 10:35   ` Steve Capper
2018-11-23 14:42   ` Catalin Marinas
2018-10-23 13:02 ` [PATCH V3 5/5] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual
2018-11-08 10:36   ` Steve Capper
2018-11-23 14:42   ` Catalin Marinas
2018-11-23 15:08 ` [PATCH V3 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025074532.GM18839@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=Steven.Price@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=punit.agrawal@arm.com \
    --cc=steve.capper@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).