From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks()
Date: Thu, 25 Oct 2018 17:28:27 +0900 [thread overview]
Message-ID: <20181025082827.GC20702@jagdpanzerIV> (raw)
In-Reply-To: <20181025081108.GB26561@osiris>
On (10/25/18 10:11), Heiko Carstens wrote:
> > s390 is the only architecture that is using own bust_spinlocks()
> > variant, while other arch-s seem to be OK with the common
> > implementation.
> >
> > Heiko Carstens [1] said he would prefer s390 to use the common
> > bust_spinlocks() as well:
> > I did some code archaeology and this function is unchanged since ~17
> > years. When it was introduced it was close to identical to the x86
> > variant. All other architectures use the common code variant in the
> > meantime. So if we change this I'd prefer that we switch s390 to the
> > common code variant as well. Right now I can't see a reason for not
> > doing that
> >
> > This patch removes s390 bust_spinlocks() and drops the weak attribute
> > from the common bust_spinlocks() version.
> >
> > [1] lkml.kernel.org/r/20181025062800.GB4037@osiris
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> > arch/s390/mm/fault.c | 24 ------------------------
> > lib/bust_spinlocks.c | 6 +++---
> > 2 files changed, 3 insertions(+), 27 deletions(-)
>
> I gave this some testing and forced panic/die in interrupt as well as
> process context with different consoles as well as single and multi
> cpu systems. Everything still seems to work.
That was quick ;) Thanks.
> So I'm applying this to our internal queue first. It will hit upstream
> latest in the next merge window if there aren't any issues found.
Sure; sounds like a plan.
-ss
prev parent reply other threads:[~2018-10-25 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 4:30 [PATCH] s390/fault: use wake_up_klogd() in bust_spinlocks() Sergey Senozhatsky
2018-10-24 4:34 ` Sergey Senozhatsky
2018-10-25 6:28 ` Heiko Carstens
2018-10-25 6:48 ` Sergey Senozhatsky
2018-10-25 7:05 ` Sergey Senozhatsky
2018-10-25 8:11 ` Heiko Carstens
2018-10-25 8:28 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025082827.GC20702@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).