From: Lee Jones <lee.jones@linaro.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mfd: mt6397: Do not call irq_domain_remove if PMIC unsupported
Date: Thu, 25 Oct 2018 10:10:01 +0100 [thread overview]
Message-ID: <20181025091001.GM4939@dell> (raw)
In-Reply-To: <20181022025505.27919-1-drinkcat@chromium.org>
On Mon, 22 Oct 2018, Nicolas Boichat wrote:
> If the PMIC ID is unknown, the current code would call
> irq_domain_remove and panic, as pmic->irq_domain is only
> initialized by mt6397_irq_init.
>
> Return immediately with an error, if the chip ID is unsupported.
>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
> drivers/mfd/mt6397-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied for v4.21, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-10-25 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 2:55 [PATCH] mfd: mt6397: Do not call irq_domain_remove if PMIC unsupported Nicolas Boichat
2018-10-25 9:10 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025091001.GM4939@dell \
--to=lee.jones@linaro.org \
--cc=drinkcat@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).