linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Renato Lui Geh <renatogeh@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Renato Lui Geh <renatogeh@gmail.com>,
	Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
	pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	alexandru.Ardelean@analog.com, stefan.popa@analog.com,
	giuliano.belinassi@usp.br, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-usp@googlegroups.com
Subject: Re: [PATCH] staging: iio: ad7780: update voltage on read
Date: Thu, 25 Oct 2018 11:26:36 -0300	[thread overview]
Message-ID: <20181025142635.3apgyaxzhr73kehc@renatolg> (raw)
In-Reply-To: <c958f5fc-2a58-8471-62a4-20b0c7267bd0@metafoo.de>

Hi,

Thanks for the quick review. :)

>But please create one patch per issue and do not put unrelated changes into
>the same patch.

Should I resend this patch as a patchset containing the two changes?

>Also your mail client seems to have replaced tabs in the patch with spaces,
>this means the patch will not apply cleanly. Check the
>Documentation/email-clients.txt file for some hints how to configure your
>mail client so it will not break patches.

From my end my original email patch appears to have tabs instead of
spaces. I redownloaded my email and vim shows that the indentation has
the ^I tab characters. But when downloading your reply it was converted
to spaces. Am I missing something?

Thanks again,
Renato


  reply	other threads:[~2018-10-25 14:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 13:32 [PATCH] staging: iio: ad7780: update voltage on read Renato Lui Geh
2018-10-25 13:38 ` Lars-Peter Clausen
2018-10-25 14:26   ` Renato Lui Geh [this message]
2018-10-25 14:55     ` Himanshu Jha
2018-10-25 16:01       ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025142635.3apgyaxzhr73kehc@renatolg \
    --to=renatogeh@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=giuliano.belinassi@usp.br \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).