linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] cgroup changes for v4.20-rc1
@ 2018-10-25 14:40 Tejun Heo
  2018-10-26  0:16 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2018-10-25 14:40 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, cgroups, Li Zefan, Johannes Weiner

Hello, Linus.

All trivial changes - simplification, typo fix and adding
cond_resched() in a netclassid update loop.

Thanks.

The following changes since commit 02214bfc89c71bcc5167f653994cfa5c57f10ff1:

  Merge tag 'media/v4.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media (2018-09-24 15:16:41 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-4.20

for you to fetch changes up to a90e90b7d55e789c71d85b946ffb5c1ab2f137ca:

  cgroup, netclassid: add a preemption point to write_classid (2018-10-23 12:58:17 -0700)

----------------------------------------------------------------
Andrey Ignatov (1):
      cgroup: Simplify cgroup_ancestor

Michal Hocko (1):
      cgroup, netclassid: add a preemption point to write_classid

Rami Rosen (1):
      rdmacg: fix a typo in rdmacg documentation

 Documentation/cgroup-v1/rdma.txt |  2 +-
 include/linux/cgroup.h           | 15 +++------------
 net/core/netclassid_cgroup.c     |  1 +
 3 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/Documentation/cgroup-v1/rdma.txt b/Documentation/cgroup-v1/rdma.txt
index af618171e0eb..9bdb7fd03f83 100644
--- a/Documentation/cgroup-v1/rdma.txt
+++ b/Documentation/cgroup-v1/rdma.txt
@@ -27,7 +27,7 @@ cgroup.
 Currently user space applications can easily take away all the rdma verb
 specific resources such as AH, CQ, QP, MR etc. Due to which other applications
 in other cgroup or kernel space ULPs may not even get chance to allocate any
-rdma resources. This can leads to service unavailability.
+rdma resources. This can lead to service unavailability.
 
 Therefore RDMA controller is needed through which resource consumption
 of processes can be limited. Through this controller different rdma
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 32c553556bbd..e03a92430383 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -567,20 +567,11 @@ static inline bool cgroup_is_descendant(struct cgroup *cgrp,
 static inline struct cgroup *cgroup_ancestor(struct cgroup *cgrp,
 					     int ancestor_level)
 {
-	struct cgroup *ptr;
-
 	if (cgrp->level < ancestor_level)
 		return NULL;
-
-	for (ptr = cgrp;
-	     ptr && ptr->level > ancestor_level;
-	     ptr = cgroup_parent(ptr))
-		;
-
-	if (ptr && ptr->level == ancestor_level)
-		return ptr;
-
-	return NULL;
+	while (cgrp && cgrp->level > ancestor_level)
+		cgrp = cgroup_parent(cgrp);
+	return cgrp;
 }
 
 /**
diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c
index 5e4f04004a49..7bf833598615 100644
--- a/net/core/netclassid_cgroup.c
+++ b/net/core/netclassid_cgroup.c
@@ -106,6 +106,7 @@ static int write_classid(struct cgroup_subsys_state *css, struct cftype *cft,
 		iterate_fd(p->files, 0, update_classid_sock,
 			   (void *)(unsigned long)cs->classid);
 		task_unlock(p);
+		cond_resched();
 	}
 	css_task_iter_end(&it);
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] cgroup changes for v4.20-rc1
  2018-10-25 14:40 [GIT PULL] cgroup changes for v4.20-rc1 Tejun Heo
@ 2018-10-26  0:16 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2018-10-26  0:16 UTC (permalink / raw)
  To: tj; +Cc: Linux Kernel Mailing List, cgroups, lizefan, hannes

On Thu, Oct 25, 2018 at 7:40 AM Tejun Heo <tj@kernel.org> wrote:
>
> All trivial changes - simplification, typo fix and adding
> cond_resched() in a netclassid update loop.

Thanks, pulled,

                      Linus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-26  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 14:40 [GIT PULL] cgroup changes for v4.20-rc1 Tejun Heo
2018-10-26  0:16 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).