linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>, Eyal Reizer <eyalr@ti.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Anders Roxell <anders.roxell@linaro.org>
Subject: Re: Regression: OOPs on boot due to "wlcore: Add support for optional wakeirq"
Date: Thu, 25 Oct 2018 10:26:01 -0700	[thread overview]
Message-ID: <20181025172601.GA31348@atomide.com> (raw)
In-Reply-To: <CALAqxLVOEVP2g6tPc1RF8mEgfffwWVHSuwrvv_a+oB2d0Jp8rg@mail.gmail.com>

* John Stultz <john.stultz@linaro.org> [181025 17:04]:
> Hey Tony,
>   In testing linus/master on my hikey board, I'm hitting the following
> OOPS on bootup:
> 
> [    1.870279] Unable to handle kernel read from unreadable memory at
...
> [    1.870485]  wl1271_probe+0x210/0x350
> [    1.870491]  sdio_bus_probe+0x100/0x128
...
> I've bisected it down to 3c83dd577c7f ("wlcore: Add support for
> optional wakeirq").
> 
> It seems since we don't have a wakeirq value in the dts, the wakeirq
> value in wl1271_probe() is zero, which then causes trouble in
> irqd_get_trigger_type(irq_get_irq_data(wakeirq)).
> 
> Should we check wakeirq before we set the second elements of res[]?

Oh sorry about that, yeah I'll take a look and post a patch ASAP.
Hmm for me value 0 there causes no errors looks like.

Regards,

Tony

      parent reply	other threads:[~2018-10-25 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 17:04 Regression: OOPs on boot due to "wlcore: Add support for optional wakeirq" John Stultz
2018-10-25 17:15 ` John Stultz
2018-10-25 17:31   ` Tony Lindgren
2018-10-25 17:33   ` Kalle Valo
2018-10-25 17:26 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025172601.GA31348@atomide.com \
    --to=tony@atomide.com \
    --cc=anders.roxell@linaro.org \
    --cc=eyalr@ti.com \
    --cc=john.stultz@linaro.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).