linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled
@ 2018-10-25 18:09 Florian Fainelli
  2018-10-25 18:25 ` Eric W. Biederman
  2018-10-25 18:30 ` Souptick Joarder
  0 siblings, 2 replies; 7+ messages in thread
From: Florian Fainelli @ 2018-10-25 18:09 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: andrew, Florian Fainelli, Russell King, Eric W. Biederman,
	Tony Lindgren, Souptick Joarder, open list

Some software such as perf makes unconditional use of the special
[vectors] page which is only provided when CONFIG_KUSER_HELPERS is
enabled in the kernel.

Facilitate the debugging of such situations by printing a debug message
to the kernel log showing the task name and the faulting address.

Suggested-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/arm/mm/fault.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index f4ea4c62c613..f17471fbc1c4 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -173,6 +173,11 @@ __do_user_fault(struct task_struct *tsk, unsigned long addr,
 		show_regs(regs);
 	}
 #endif
+#ifndef CONFIG_KUSER_HELPERS
+	if ((sig == SIGSEGV) && ((addr & PAGE_MASK) == 0xffff0000))
+		printk(KERN_DEBUG "%s: CONFIG_KUSER_HELPERS disabled at 0x%08lx\n",
+		       tsk->comm, addr);
+#endif
 
 	tsk->thread.address = addr;
 	tsk->thread.error_code = fsr;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-10-25 21:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 18:09 [PATCH] ARM: mm: Facilitate debugging CONFIG_KUSER_HELPERS disabled Florian Fainelli
2018-10-25 18:25 ` Eric W. Biederman
2018-10-25 18:50   ` Florian Fainelli
2018-10-25 18:30 ` Souptick Joarder
2018-10-25 18:48   ` Florian Fainelli
2018-10-25 19:06     ` Souptick Joarder
2018-10-25 21:20   ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).