linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	rteysseyre@gmail.com, bjorn.andersson@linaro.org,
	broonie@kernel.org, linus.walleij@linaro.org,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: More checks for patterns? was: Fix pattern handling optimalization
Date: Thu, 25 Oct 2018 23:24:29 +0200	[thread overview]
Message-ID: <20181025212429.GB18016@amd> (raw)
In-Reply-To: <79c29d20-ae6a-4a12-28fa-93d7305a0623@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]


We don't want brightness < 0, but this may not be best way to do
this. We also don't want brightness > max_brightness, but I'm not sure
this check is effective.

We probably also don't want pattern where all the delta_t s are zero.

I came up with this so far....
   	    	       	    	    	      	  	    Pavel



diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
index ce7acd1..bc5f495 100644
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -250,9 +251,16 @@ static ssize_t pattern_trig_store_patterns(struct led_classdev *led_cdev,
 
 	while (offset < count - 1 && data->npatterns < MAX_PATTERNS) {
 		cr = 0;
-		ccount = sscanf(buf + offset, "%d %u %n",
+		ccount = sscanf(buf + offset, "%u %u %n",
 				&data->patterns[data->npatterns].brightness,
 				&data->patterns[data->npatterns].delta_t, &cr);
+
+		if (data->patterns[data->npatterns].brightness > data->led_cdev->max_brightness) {
+			data->npatterns = 0;
+			err = -EINVAL;
+			goto out;
+		}
+			 
 		if (ccount != 2) {
 			data->npatterns = 0;
 			err = -EINVAL;




-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-10-25 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  4:07 [PATCH v15 1/2] leds: core: Introduce LED pattern trigger Baolin Wang
2018-10-11  4:07 ` [PATCH v15 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Baolin Wang
2018-10-11 20:07 ` [PATCH v15 1/2] leds: core: Introduce LED pattern trigger Jacek Anaszewski
2018-10-12  1:40   ` Baolin Wang
2018-10-24  8:34     ` Pavel Machek
2018-10-24  8:31   ` Pavel Machek
2018-10-24 19:17     ` Jacek Anaszewski
2018-10-24 19:55       ` Pavel Machek
2018-10-24 20:44       ` [PATCH] Fix pattern handling optimalization Pavel Machek
2018-10-25 19:17         ` Jacek Anaszewski
2018-10-25 21:24           ` Pavel Machek [this message]
2018-10-26  8:02             ` More checks for patterns? was: " Baolin Wang
2018-10-26 19:56             ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025212429.GB18016@amd \
    --to=pavel@ucw.cz \
    --cc=baolin.wang@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rteysseyre@gmail.com \
    --subject='Re: More checks for patterns? was: Fix pattern handling optimalization' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).