linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lars Poeschel <poeschel@lemonage.de>
Cc: devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs
Date: Thu, 25 Oct 2018 16:54:45 -0500	[thread overview]
Message-ID: <20181025215445.GA16550@bogus> (raw)
In-Reply-To: <20181025132937.24405-2-poeschel@lemonage.de>

On Thu, Oct 25, 2018 at 03:29:33PM +0200, Lars Poeschel wrote:
> Add a simple binding doc for the pn532.
> 
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> Changes in v3:
> - seperate binding doc instead of entry in trivial-devices.txt
> 
>  .../devicetree/bindings/nfc/pn532.txt         | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/nfc/pn532.txt
> 
> diff --git a/Documentation/devicetree/bindings/nfc/pn532.txt b/Documentation/devicetree/bindings/nfc/pn532.txt
> new file mode 100644
> index 000000000000..a2df72a5f504
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nfc/pn532.txt
> @@ -0,0 +1,31 @@
> +NXP PN532 NFC Chip

What about the PN533?

> +
> +Required properties:
> +- compatible: Should be
> +    - "nxp,pn532" Place a node with this inside the devicetree node of the bus
> +                  where the NFC chip is connected to.
> +                  Currently the kernel has phy bindings for uart and i2c.
> +    - "nxp,pn532-i2c" (DEPRECATED) only works for the i2c binding.
> +    - "nxp,pn533-i2c" (DEPRECATED) only works for the i2c binding.
> +
> +There are no additional properties provided by the driver at the moment.

I2C requires reg.

> +
> +Example uart:
> +
> +uart4: serial@49042000 {
> +        compatible = "ti,omap3-uart";
> +
> +        pn532: nfc {
> +                compatible = "nxp,pn532";
> +        };
> +};
> +
> +Example i2c:
> +
> +i2c1: i2c@0 {
> +        compatible = "ti,omap3-i2c";
> +
> +        pn532: nfc {
> +                compatible = "nxp,pn532";
> +        };
> +};
> -- 
> 2.19.1
> 

  reply	other threads:[~2018-10-25 21:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 13:29 [PATCH v3 1/5] nfc: pn533: i2c: "pn532" as dt compatible string Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs Lars Poeschel
2018-10-25 21:54   ` Rob Herring [this message]
2018-10-26  7:59     ` Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 3/5] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-28 10:27   ` Johan Hovold
2018-10-28 13:46     ` Marcel Holtmann
2018-10-28 14:35       ` Johan Hovold
2018-10-29 10:02     ` Lars Poeschel
2018-10-29 11:07       ` Johan Hovold
2018-10-29 15:51         ` Lars Poeschel
2018-10-29 16:13           ` Johan Hovold
2018-10-25 13:29 ` [PATCH v3 4/5] nfc: pn533: Add autopoll capability Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 5/5] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025215445.GA16550@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=poeschel@lemonage.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).