From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE120ECDE46 for ; Fri, 26 Oct 2018 14:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 517D220651 for ; Fri, 26 Oct 2018 14:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="Zye2fXLE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 517D220651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbeJZXVV (ORCPT ); Fri, 26 Oct 2018 19:21:21 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:42654 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727525AbeJZXVU (ORCPT ); Fri, 26 Oct 2018 19:21:20 -0400 Received: by mail-yb1-f196.google.com with SMTP id o204-v6so555345yba.9 for ; Fri, 26 Oct 2018 07:43:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bPGBit+EARwp+XE6uiw05Rweh/e+dcok4inGsPRnxfs=; b=Zye2fXLEuzcCvg7TF4Vep83x5kaJrIUxqLmJHs7SVK8M8JJHZYIxbYJQMovIDIVFFm iC+7OpAAkvVQd1rWLIy/NF7x46ZouyBgbu0DOhbA4CTMluu4YwxpNfGnuNdfhxFuSCL4 yEZ0AU5b9yez5VSJFPHTcL+wbHtzKrbcee/sVbjvL8sa0b+gv1VvLASppPlC9kmUZpEp X46BqJFYNbOhlfWm/cpboOlQ3qbFanj6/pfdaTw8nIeCHhfBSy/U2CAblVYcIS1iN653 Q9f7jAio0dyGAoxXgnf6GxYhWtnctchrn6RFwEs/Qthird7/uR+/khDasKfzKr4ebrGT ad9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bPGBit+EARwp+XE6uiw05Rweh/e+dcok4inGsPRnxfs=; b=CkffTb0iJC2RIt77IOdEP8W9uIZ+F8kFHF9LaNp34YByJIPzF3u7Tif2y8auP2Kt4M wZjmkkUN+DV61pNnaP6/tkMrU0QRkhwffC88deSIy0wWSUBuCAJMmMA1PGnOeFLu8cD+ v5n5RmEtQApxrfMU8Gpc2m+VoWFbIWFQUQrvLKiRnlOcm2vqO7PALDOzZMEphHGMDqng dXu+iTO9rHvzpo/eJi7hwmU37LhowRIXe22pQ3f2Ubph4zvJ9An+g7moij8aSUmt1Ii8 EDTep/vah9Bi/TrOiveckDobnxIfQiCxNW98FBu2iR8NkJp/pDYvAxvulb7uMiYgKbLI 7uVg== X-Gm-Message-State: AGRZ1gJltQdKvQX5DKEer6+yKW5yLvUireYLIO7p5UcDRp8ekqQKDVQY xNKOlPOEF0hrITI4+S0viaDlpQ== X-Google-Smtp-Source: AJdET5feeNluxyM4jzSTbXCMYroTSB8LHhRBb7WqCzFu1OBtaNjfXU5Iw5FIhXHp53R1S2GEEmXa0g== X-Received: by 2002:a5b:187:: with SMTP id r7-v6mr3794372ybl.517.1540565038150; Fri, 26 Oct 2018 07:43:58 -0700 (PDT) Received: from localhost ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id 200-v6sm2757015ywq.97.2018.10.26.07.43.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Oct 2018 07:43:57 -0700 (PDT) Date: Fri, 26 Oct 2018 10:43:56 -0400 From: Sean Paul To: Douglas Anderson Cc: Sean Paul , Thierry Reding , Sandeep Panda , linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , David Airlie , Mark Rutland Subject: Re: [PATCH v2 5/6] dt-bindings: drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Message-ID: <20181026144356.GS154160@art_vandelay> References: <20181025222134.174583-1-dianders@chromium.org> <20181025222134.174583-5-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181025222134.174583-5-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 25, 2018 at 03:21:33PM -0700, Douglas Anderson wrote: > As far as I can tell the bindings that were added in commit > 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel > bindings") weren't actually for Innolux TV123WAM but were actually for > Innolux P120ZDG-BF1. > > As far as I can tell the Innolux TV123WAM isn't a real panel and but > it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1. > Let's unmosh. > > Here's my evidence: > > * Searching for TV123WAM on the Internet turns up a TI panel. While > it's possible that an Innolux panel has the same model number as the > TI Panel, it seems a little doubtful. Looking up the datasheet from > the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm. > > * As far as I know, the patch adding the Innolux Panel was supposed to > be for the board that's sitting in front of me as I type this > (support for that board is not yet upstream). On the back of that > panel I see Innolux P120ZDZ-EZ1 rev B1. > > * Someone pointed me at a datasheet that's supposed to be for the > panel in front of me (sorry, I can't share the datasheet). That > datasheet has the string "p120zdg-bf1" > > * If I search for "P120ZDG-BF1" on the Internet I get hits for panels > that are 2160x1440. They don't have datasheets, but the fact that > the resolution matches is a good sign. > > While we doing the rename, also mention that no-hpd can be used with > this panel. See the previous patch in this series ("drm/panel: > simple: Add "no-hpd" delay for Innolux TV123WAM"). > > Fixes: 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings") > Signed-off-by: Douglas Anderson > Reviewed-by: Rob Herring I didn't see your v2 when I replied to the v1 patch, so for the record, Reviewed-by: Sean Paul Also note to whoever applies this to -misc, v1 also had Reviewed-by: Abhinav Kumar Sean > Cc: Sandeep Panda > --- > > Changes in v2: None > > .../{innolux,tv123wam.txt => innolux,p120zdg-bf1.txt} | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > rename Documentation/devicetree/bindings/display/panel/{innolux,tv123wam.txt => innolux,p120zdg-bf1.txt} (70%) > > diff --git a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt b/Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt > similarity index 70% > rename from Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt > rename to Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt > index a9b35265fa13..513f03466aba 100644 > --- a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt > +++ b/Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt > @@ -1,20 +1,22 @@ > -Innolux TV123WAM 12.3 inch eDP 2K display panel > +Innolux P120ZDG-BF1 12.02 inch eDP 2K display panel > > This binding is compatible with the simple-panel binding, which is specified > in simple-panel.txt in this directory. > > Required properties: > -- compatible: should be "innolux,tv123wam" > +- compatible: should be "innolux,p120zdg-bf1" > - power-supply: regulator to provide the supply voltage > > Optional properties: > - enable-gpios: GPIO pin to enable or disable the panel > - backlight: phandle of the backlight device attached to the panel > +- no-hpd: If HPD isn't hooked up; add this property. > > Example: > panel_edp: panel-edp { > - compatible = "innolux,tv123wam"; > + compatible = "innolux,p120zdg-bf1"; > enable-gpios = <&msmgpio 31 GPIO_ACTIVE_LOW>; > power-supply = <&pm8916_l2>; > backlight = <&backlight>; > + no-hpd; > }; > -- > 2.19.1.568.g152ad8e336-goog > -- Sean Paul, Software Engineer, Google / Chromium OS