From: Jonathan Cameron <jic23@kernel.org>
To: Dan O'Donovan <dan@emutex.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Carlos Iglesias <carlos.iglesias@emutex.com>,
Javier Arteaga <javier@emutex.com>
Subject: Re: [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs
Date: Sun, 28 Oct 2018 15:35:51 +0000 [thread overview]
Message-ID: <20181028153551.6f2cccac@archlinux> (raw)
In-Reply-To: <1540481742-23596-2-git-send-email-dan@emutex.com>
On Thu, 25 Oct 2018 16:35:40 +0100
Dan O'Donovan <dan@emutex.com> wrote:
> From: Javier Arteaga <javier@emutex.com>
>
> The datasheets for ADC122S021 and ADC124S021 list two more
> pin-compatible alternatives for each device.
>
> Add their IDs as compatible strings.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Signed-off-by: Javier Arteaga <javier@emutex.com>
> Signed-off-by: Dan O'Donovan <dan@emutex.com>
> ---
> .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 9 ++++++++-
> drivers/iio/adc/ti-adc128s052.c | 16 ++++++++++++----
> 2 files changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> index daa2b2c..c07ce1a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -1,7 +1,14 @@
> * Texas Instruments' ADC128S052, ADC122S021 and ADC124S021 ADC chip
>
> Required properties:
> - - compatible: Should be "ti,adc128s052", "ti,adc122s021" or "ti,adc124s021"
> + - compatible: Should be one of:
> + - "ti,adc128s052"
Hmm. Ideally I think these should be in 'alphabetical' order. However
I can see a certain logic to having the part whose name we are using for
the driver listed first..
Not important enough to change.
> + - "ti,adc122s021"
> + - "ti,adc122s051"
> + - "ti,adc122s101"
> + - "ti,adc124s021"
> + - "ti,adc124s051"
> + - "ti,adc124s101"
> - reg: spi chip select number for the device
> - vref-supply: The regulator supply for ADC reference voltage
>
> diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
> index 7cf39b3..e6716c3 100644
> --- a/drivers/iio/adc/ti-adc128s052.c
> +++ b/drivers/iio/adc/ti-adc128s052.c
> @@ -186,15 +186,23 @@ static int adc128_remove(struct spi_device *spi)
> static const struct of_device_id adc128_of_match[] = {
> { .compatible = "ti,adc128s052", },
> { .compatible = "ti,adc122s021", },
> + { .compatible = "ti,adc122s051", },
> + { .compatible = "ti,adc122s101", },
> { .compatible = "ti,adc124s021", },
> - { /* sentinel */ },
> + { .compatible = "ti,adc124s051", },
> + { .compatible = "ti,adc124s101", },
> + { }
Dropping then sentinel shouldn't have occurred in this patch.
I don't really care if it is there or not personally but we shouldn't be
making changes without clear benefit. I'll put it back.
> };
> MODULE_DEVICE_TABLE(of, adc128_of_match);
>
> static const struct spi_device_id adc128_id[] = {
> - { "adc128s052", 0}, /* index into adc128_config */
> - { "adc122s021", 1},
> - { "adc124s021", 2},
> + { "adc128s052", 0 }, /* index into adc128_config */
> + { "adc122s021", 1 },
> + { "adc122s051", 1 },
> + { "adc122s101", 1 },
> + { "adc124s021", 2 },
> + { "adc124s051", 2 },
> + { "adc124s101", 2 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, adc128_id);
next prev parent reply other threads:[~2018-10-28 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 21:38 [PATCH v2 0/3] iio: adc128s052: add matching options Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 1/3] iio: adc128s052: Add pin-compatible IDs Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 2/3] iio: adc128s052: add ACPI _HID AANT1280 Javier Arteaga
2018-04-23 22:08 ` Andy Shevchenko
2018-04-24 10:51 ` Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 3/3] iio: adc128s052: reuse "compatible" for ACPI _DSD Javier Arteaga
2018-10-25 15:35 ` [PATCH v3 0/3] iio: adc128s052: add matching options Dan O'Donovan
2018-10-25 15:35 ` [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs Dan O'Donovan
2018-10-28 15:35 ` Jonathan Cameron [this message]
2018-10-30 19:37 ` Rob Herring
2018-10-25 15:35 ` [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280 Dan O'Donovan
2018-10-25 17:46 ` Andy Shevchenko
2018-10-26 10:13 ` Dan O'Donovan
2018-10-26 12:12 ` Andy Shevchenko
2018-10-27 17:14 ` Himanshu Jha
2018-10-28 11:42 ` Jonathan Cameron
2018-10-28 11:56 ` Jonathan Cameron
2018-10-25 15:35 ` [PATCH v3 3/3] iio: adc128s052: use SPDX-License-Identifier Dan O'Donovan
2018-10-28 11:58 ` Jonathan Cameron
2018-10-25 17:49 ` [PATCH v3 0/3] iio: adc128s052: add matching options Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028153551.6f2cccac@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=carlos.iglesias@emutex.com \
--cc=dan@emutex.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@emutex.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).