From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E733C2BC61 for ; Sun, 28 Oct 2018 22:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 536C42054F for ; Sun, 28 Oct 2018 22:07:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 536C42054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbeJ2Gxz (ORCPT ); Mon, 29 Oct 2018 02:53:55 -0400 Received: from sauhun.de ([88.99.104.3]:57934 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725841AbeJ2Gxy (ORCPT ); Mon, 29 Oct 2018 02:53:54 -0400 Received: from localhost (unknown [87.113.172.131]) by pokefinder.org (Postfix) with ESMTPSA id B5A714A1CA7; Sun, 28 Oct 2018 23:07:55 +0100 (CET) Date: Sun, 28 Oct 2018 22:07:55 +0000 From: Wolfram Sang To: Masahiro Yamada Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] i2c: uniphier-f: make driver robust against concurrency Message-ID: <20181028220755.GB1882@kunai> References: <1539658909-26691-1-git-send-email-yamada.masahiro@socionext.com> <1539658909-26691-2-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline In-Reply-To: <1539658909-26691-2-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 16, 2018 at 12:01:47PM +0900, Masahiro Yamada wrote: > This is unlikely to happen, but it is possible for a CPU to enter > the interrupt handler just after wait_for_completion_timeout() has > expired. If this happens, the hardware is accessed from multiple > contexts concurrently. >=20 > Disable the IRQ after wait_for_completion_timeout(), and do nothing > from the handler when the IRQ is disabled. >=20 > Fixes: 6a62974b667f ("i2c: uniphier_f: add UniPhier FIFO-builtin I2C driv= er") > Signed-off-by: Masahiro Yamada Applied to for-next, thanks! --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlvWMzYACgkQFA3kzBSg Kbbv3Q//UHC1ylz0MLVT9hMtFF15YgjiWLWTmF1Z4+nkZYGuZbwAcLSMNCgJOnUQ 9FejiSk1/vbYDw+PqeyNSLcaTBVdmX4TuS7ssFH9PVPMFK4wi4ZknrxFrPBJBsU1 1iNd19i+HnjxbDl5VDTrf7wXvVTW8/aDMzb+LcopjhwE1/EX1ApiflVH6vqknDuc 7kwZFYVLCFQjp/GMdz5NHWj6TTde2CTF5PPC7DDwmQagGyf/Jf1bnVuZb0uad1U+ uyHgTvC7czX7erPJ3QzlQJvEuA0MyiUEU6qbVqkHv6kXFdXGSypvXs5xkdhFarkT FL6PbunWtXAx42pJ9CETdRoSSIQTib81YoVNNGFb4rViPObuK8ek5x3MmKt2jCLm uCqyalcdRte9PkwEh6Wa6NL27WlaAhMnoRPQZevMRmF4q6RKzT3LNuzCPPsc+Hob jVdmVUDGtFHAW1FAczDFOnwWZWvU6QZOopMcdMLwf2crGBN3hGNxW3CHmrRsqiQs DRmHKrjzn0z18DPrE0Mxn0EfGtp1xfO9APmmLzq54zwsA+mvEeGRgavxumDqdhYt GkxGIXCRlMqYvFposQlxZ3dD3jgoh8xD9r2nT0w8qlyfWeJugyH8Mf/n3l9gOu5j hWHgOwtCBb1DUSJVsQMuKEUA/bFLwLdqkG1n4hKhAsqtGxnmSI8= =9M1/ -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd--