From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: aviad.krawczyk@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ndesaulniers@google.com
Subject: Re: [PATCH] hinic: Fix l4_type parameter in hinic_task_set_tunnel_l4
Date: Mon, 29 Oct 2018 20:43:56 -0700 (PDT) [thread overview]
Message-ID: <20181029.204356.2257052616319742165.davem@davemloft.net> (raw)
In-Reply-To: <20181029105158.6340-1-natechancellor@gmail.com>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Mon, 29 Oct 2018 03:51:58 -0700
> Clang warns:
>
> drivers/net/ethernet/huawei/hinic/hinic_tx.c:392:34: error: implicit
> conversion from enumeration type 'enum hinic_l4_tunnel_type' to
> different enumeration type 'enum hinic_l4_offload_type'
> [-Werror,-Wenum-conversion]
> hinic_task_set_tunnel_l4(task, TUNNEL_UDP_NO_CSUM,
> ~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~
> 1 error generated.
>
> It seems that hinic_task_set_tunnel_l4 was meant to take an enum of type
> hinic_l4_tunnel_type, not hinic_l4_offload_type, given both the name of
> the functions and the values used.
>
> Fixes: cc18a7543d2f ("net-next/hinic: add checksum offload and TSO support")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied.
prev parent reply other threads:[~2018-10-30 3:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 10:51 [PATCH] hinic: Fix l4_type parameter in hinic_task_set_tunnel_l4 Nathan Chancellor
2018-10-29 17:28 ` Nick Desaulniers
2018-10-29 17:35 ` Nick Desaulniers
2018-10-30 3:52 ` David Miller
2018-10-30 3:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029.204356.2257052616319742165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviad.krawczyk@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).