From: Matthew Wilcox <willy@infradead.org>
To: miles.chen@mediatek.com
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Joe Perches <joe@perches.com>, Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCHv2] mm/page_owner: use kvmalloc instead of kmalloc
Date: Sun, 28 Oct 2018 19:30:26 -0700 [thread overview]
Message-ID: <20181029023026.GC28520@bombadil.infradead.org> (raw)
In-Reply-To: <1540779403-27622-1-git-send-email-miles.chen@mediatek.com>
On Mon, Oct 29, 2018 at 10:16:43AM +0800, miles.chen@mediatek.com wrote:
> The kbuf used by page owner is allocated by kmalloc(), which means it
> can use only normal memory and there might be a "out of memory"
> issue when we're out of normal memory.
>
> Use kvmalloc() so we can also allocate kbuf from
> normal/hihghmem on 32bit kernel.
That's a misconception:
ret = kmalloc_node(size, kmalloc_flags, node);
/*
* It doesn't really make sense to fallback to vmalloc for sub page
* requests
*/
if (ret || size <= PAGE_SIZE)
return ret;
Now, maybe this is an opportunity for us to improve kvmalloc. Maybe like
this ...
diff --git a/mm/util.c b/mm/util.c
index 8bf08b5b5760..fdf5b34d2c28 100644
--- a/mm/util.c
+++ b/mm/util.c
@@ -416,10 +416,10 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)
ret = kmalloc_node(size, kmalloc_flags, node);
/*
- * It doesn't really make sense to fallback to vmalloc for sub page
- * requests
+ * It only makes sense to fallback to vmalloc for sub page
+ * requests if we might be able to allocate highmem pages.
*/
- if (ret || size <= PAGE_SIZE)
+ if (ret || (!IS_ENABLED(CONFIG_HIGHMEM) && size <= PAGE_SIZE))
return ret;
return __vmalloc_node_flags_caller(size, node, flags,
prev parent reply other threads:[~2018-10-29 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 2:16 [PATCHv2] mm/page_owner: use kvmalloc instead of kmalloc miles.chen
2018-10-29 2:30 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029023026.GC28520@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=mhocko@kernel.org \
--cc=miles.chen@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).