From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Michael Thayer <michael.thayer@oracle.com>,
devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses
Date: Tue, 30 Oct 2018 10:25:39 +0100 [thread overview]
Message-ID: <20181030092539.GA10009@kroah.com> (raw)
In-Reply-To: <20181023174304.iq4ra7vafwujr3ex@smtp.gmail.com>
On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
>
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> - Make the commit message more clearer.
This patch does not apply to the latest kernel tree at all :(
Please fix up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2018-10-30 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 17:43 [PATCH v2] staging: vboxvideo: Remove unnecessary parentheses Shayenne da Luz Moura
2018-10-26 11:11 ` Hans de Goede
2018-10-30 9:25 ` Greg Kroah-Hartman [this message]
2018-10-30 23:17 ` Shayenne Moura
2018-10-30 23:48 ` [Outreachy kernel] " Sasha Levin
2018-10-31 15:05 ` Shayenne Moura
2018-10-31 6:06 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030092539.GA10009@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shayenneluzmoura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).