From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999D4C2BC61 for ; Tue, 30 Oct 2018 09:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53C5F2084A for ; Tue, 30 Oct 2018 09:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53C5F2084A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbeJ3S1H (ORCPT ); Tue, 30 Oct 2018 14:27:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62983 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbeJ3S1H (ORCPT ); Tue, 30 Oct 2018 14:27:07 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EFDA88317; Tue, 30 Oct 2018 09:34:25 +0000 (UTC) Received: from krava (unknown [10.43.17.150]) by smtp.corp.redhat.com (Postfix) with SMTP id 7698F5C559; Tue, 30 Oct 2018 09:34:20 +0000 (UTC) Date: Tue, 30 Oct 2018 10:34:18 +0100 From: Jiri Olsa To: Jiri Olsa Cc: lkml , Arnaldo Carvalho de Melo , Hartmut Knaack , Jonathan Cameron , Lars-Peter Clausen , Len Brown , Markus Mayer , Shuah Khan , Steven Rostedt , Thomas Renninger , Tzvetomir Stoyanov , Zhang Rui , "Herton R. Krzesinski" Subject: Re: [PATCH 10/10] tools gpio: Override CFLAGS assignments Message-ID: <20181030093418.GC18538@krava> References: <20181016150614.21260-1-jolsa@kernel.org> <20181022145007.GD2945@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181022145007.GD2945@krava> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 30 Oct 2018 09:34:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping thanks, jirka On Mon, Oct 22, 2018 at 04:50:07PM +0200, Jiri Olsa wrote: > On Tue, Oct 16, 2018 at 05:06:05PM +0200, Jiri Olsa wrote: > > hi, > > while hardening some of the tools rpm, we noticed we > > can't pass build flags to some of them. > > > > Sending separate tools fixes for what we found. It's > > mostly override for CFLAGS and adding LDFLAGS to the > > build commands. > > > > thanks, > > jirka > > > > > > Cc: Arnaldo Carvalho de Melo > > Cc: Hartmut Knaack > > Cc: Jonathan Cameron > > Cc: Lars-Peter Clausen > > Cc: Len Brown > > Cc: Markus Mayer > > Cc: Shuah Khan > > Cc: Signed-off-by: Len Brown > > Cc: Steven Rostedt > > Cc: Thomas Renninger > > Cc: Tzvetomir Stoyanov (VMware) > > Cc: Zhang Rui > > --- > > Jiri Olsa (10): > > tools lib traceevent: Use LDFLAGS in the build commands > > tools perf: Pass build flags to traceevent build > > tools cpupower debug: Allow to use outside build flags > > tools cpupower: Override CFLAGS assignments > > tools power x86_energy_perf_policy: Override CFLAGS assignments and add LDFLAGS to build command > > tools thermal tmon: Override CFLAGS assignments > > tools thermal tmon: Use -O3 instead of -O1 if available > > tools power turbostat: Override CFLAGS assignments and add LDFLAGS to build command > > tools iio: Override CFLAGS assignments > > tools gpio: Override CFLAGS assignments > > the last one did not get post for some reason, > attaching it now > > jirka > > > --- > So user could specify outside CFLAGS values. > > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Signed-off-by: Jiri Olsa > --- > tools/gpio/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile > index 240eda014b37..6ecdd1067826 100644 > --- a/tools/gpio/Makefile > +++ b/tools/gpio/Makefile > @@ -12,7 +12,7 @@ endif > # (this improves performance and avoids hard-to-debug behaviour); > MAKEFLAGS += -r > > -CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include > +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include > > ALL_TARGETS := lsgpio gpio-hammer gpio-event-mon > ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS)) > -- > 2.17.2 >