From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: linux-next: manual merge of the vfs tree with Linus' tree
Date: Tue, 30 Oct 2018 12:20:50 +1100 [thread overview]
Message-ID: <20181030122050.1bd82c30@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 3675 bytes --]
Hi Al,
Today's linux-next merge of the vfs tree got a conflict in:
fs/compat_ioctl.c
between commit:
77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()")
from Linus' tree and commit:
69374d063be0 ("compat_ioctl: remove pointless HCI... ioctls")
from the vfs tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/compat_ioctl.c
index 6e30949d9f77,326ceab5246a..000000000000
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@@ -429,13 -499,68 +429,6 @@@ static int mt_ioctl_trans(struct file *
#endif /* CONFIG_BLOCK */
- /* Bluetooth ioctls */
- #define HCIUARTSETPROTO _IOW('U', 200, int)
- #define HCIUARTGETPROTO _IOR('U', 201, int)
- #define HCIUARTGETDEVICE _IOR('U', 202, int)
- #define HCIUARTSETFLAGS _IOW('U', 203, int)
- #define HCIUARTGETFLAGS _IOR('U', 204, int)
-struct serial_struct32 {
- compat_int_t type;
- compat_int_t line;
- compat_uint_t port;
- compat_int_t irq;
- compat_int_t flags;
- compat_int_t xmit_fifo_size;
- compat_int_t custom_divisor;
- compat_int_t baud_base;
- unsigned short close_delay;
- char io_type;
- char reserved_char[1];
- compat_int_t hub6;
- unsigned short closing_wait; /* time to wait before closing */
- unsigned short closing_wait2; /* no longer used... */
- compat_uint_t iomem_base;
- unsigned short iomem_reg_shift;
- unsigned int port_high;
- /* compat_ulong_t iomap_base FIXME */
- compat_int_t reserved[1];
-};
-
-static int serial_struct_ioctl(struct file *file,
- unsigned cmd, struct serial_struct32 __user *ss32)
-{
- typedef struct serial_struct32 SS32;
- int err;
- struct serial_struct __user *ss = compat_alloc_user_space(sizeof(*ss));
- __u32 udata;
- unsigned int base;
- unsigned char *iomem_base;
-
- if (ss == NULL)
- return -EFAULT;
- if (cmd == TIOCSSERIAL) {
- if (copy_in_user(ss, ss32, offsetof(SS32, iomem_base)) ||
- get_user(udata, &ss32->iomem_base))
- return -EFAULT;
- iomem_base = compat_ptr(udata);
- if (put_user(iomem_base, &ss->iomem_base) ||
- convert_in_user(&ss32->iomem_reg_shift,
- &ss->iomem_reg_shift) ||
- convert_in_user(&ss32->port_high, &ss->port_high) ||
- put_user(0UL, &ss->iomap_base))
- return -EFAULT;
- }
- err = do_ioctl(file, cmd, (unsigned long)ss);
- if (cmd == TIOCGSERIAL && err >= 0) {
- if (copy_in_user(ss32, ss, offsetof(SS32, iomem_base)) ||
- get_user(iomem_base, &ss->iomem_base))
- return -EFAULT;
- base = (unsigned long)iomem_base >> 32 ?
- 0xffffffff : (unsigned)(unsigned long)iomem_base;
- if (put_user(base, &ss32->iomem_base) ||
- convert_in_user(&ss->iomem_reg_shift,
- &ss32->iomem_reg_shift) ||
- convert_in_user(&ss->port_high, &ss32->port_high))
- return -EFAULT;
- }
- return err;
-}
--
#define RTC_IRQP_READ32 _IOR('p', 0x0b, compat_ulong_t)
#define RTC_IRQP_SET32 _IOW('p', 0x0c, compat_ulong_t)
#define RTC_EPOCH_READ32 _IOR('p', 0x0d, compat_ulong_t)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-10-30 1:20 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 1:20 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-01-05 0:10 linux-next: manual merge of the vfs tree with Linus' tree Stephen Rothwell
2024-01-05 0:20 ` Steven Rostedt
2024-01-01 22:36 Stephen Rothwell
2020-07-28 1:09 Stephen Rothwell
2020-07-27 1:37 Stephen Rothwell
2020-03-31 23:55 Stephen Rothwell
2019-01-02 1:32 Stephen Rothwell
2019-01-02 1:18 Stephen Rothwell
2018-06-01 1:52 Stephen Rothwell
2018-01-01 22:54 Stephen Rothwell
2017-12-03 23:05 Stephen Rothwell
2017-11-28 23:53 Stephen Rothwell
2017-11-30 23:36 ` Stephen Rothwell
2017-11-17 0:42 Stephen Rothwell
2017-03-30 0:07 Stephen Rothwell
2017-02-27 0:10 Stephen Rothwell
2017-02-27 8:28 ` David Howells
2017-01-22 23:36 Stephen Rothwell
2016-10-10 0:20 Stephen Rothwell
2016-05-19 1:17 Stephen Rothwell
2016-05-19 2:02 ` Steve French
2016-05-02 0:49 Stephen Rothwell
2016-05-02 0:43 Stephen Rothwell
2016-05-02 0:38 Stephen Rothwell
2016-03-13 23:24 Stephen Rothwell
2015-12-07 1:46 Stephen Rothwell
2015-02-22 0:57 Stephen Rothwell
2015-02-22 0:55 Stephen Rothwell
2015-02-22 0:51 Stephen Rothwell
2015-02-22 0:46 Stephen Rothwell
2015-01-23 1:10 Stephen Rothwell
2014-05-29 3:19 Stephen Rothwell
2014-04-22 1:17 Stephen Rothwell
2014-04-22 0:50 Stephen Rothwell
2014-04-22 0:44 Stephen Rothwell
2013-11-08 1:01 Stephen Rothwell
2013-09-05 2:59 Stephen Rothwell
2013-05-02 2:00 Stephen Rothwell
2013-05-02 1:55 Stephen Rothwell
2013-05-01 2:11 Stephen Rothwell
2013-04-29 1:38 Stephen Rothwell
2012-09-24 1:45 Stephen Rothwell
2012-07-30 0:41 Stephen Rothwell
2012-07-30 0:37 Stephen Rothwell
2012-02-14 0:54 Stephen Rothwell
2012-02-14 1:43 ` Al Viro
2012-01-09 1:11 Stephen Rothwell
2012-01-09 1:32 ` Linus Torvalds
2012-01-09 2:22 ` Stephen Rothwell
2012-01-09 2:14 ` Al Viro
2010-05-28 1:31 Stephen Rothwell
2010-05-28 1:31 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030122050.1bd82c30@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).