From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D80C2BC61 for ; Tue, 30 Oct 2018 18:23:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5E132081B for ; Tue, 30 Oct 2018 18:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kHFXJGWZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5E132081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbeJaDSF (ORCPT ); Tue, 30 Oct 2018 23:18:05 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:33031 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbeJaDSF (ORCPT ); Tue, 30 Oct 2018 23:18:05 -0400 Received: by mail-pl1-f195.google.com with SMTP id x6-v6so5971527pln.0; Tue, 30 Oct 2018 11:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GAux+0psBSoJyTO71A/RhOPXt77/q0qpmdzeczJuq4g=; b=kHFXJGWZibCqmUnq0gxnQbESPeXTsppIF+8ODsEbJsUkyLBZp/z8zSsP9P91Zym5Tx 4bHKPfvWdNN3b4IPmKImqhfPZGpy8to3J25xAkeAVP4xeembGi6ATagIdrSwp77dgVFi tAqy6F4f6GPbGThAnBvNaNwSej2vr6Sy0XCAEUzOwBsxKIoxu6WL3jVxPx1TVhK3Ulmu ZxQODp11YeEEFLyv2PBNMHNTHLw4xy8GD0WehuqPkdDSWlPr2hWLQVonn1Ip1wfGmDZw wA7P/aod0T1issofJXG9FRCzxZsw8AeiTuJPzmx+tP/IQokPyFRxlzgsi05Kwv1h/6ZH PQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GAux+0psBSoJyTO71A/RhOPXt77/q0qpmdzeczJuq4g=; b=NVdfrCdWzjiehVPQ+uHHPyjZxSVVfkXumrnvFC1MZ/EKcuTrHqpCle5XDWr5CmLpXI N2v47NVFA0gG4/Bf1+Be/zWhJ94Dw7QvQExN0O+LyfQjKMzQxLmZGrzkkv+K1NhIwkip wraNQmSFXhWWs3Krcr13BA8X4FZhHq21TKtcdWjKmBNsFhJhPiaTrtRCDyaHfXpCN2/S GaEl31sSIQzd09e1DRk7HRf0aMorCzRzsliRlGIKATUedpkNatGsKX772j7Mol+BNS50 tY8F+neaNmriKNTlmmo5zf/REB94eSOiZuZH3pMLSXykpSXWDC+SslS6TAEmyAksn1/E aqaA== X-Gm-Message-State: AGRZ1gJjlPNr5oSLUHVCLa8VgutcSbNpmEiQ3qgVDQ1dDaQ/1oxTRE0d gTLA9Kpdd9ggjgNEIl7CML8= X-Google-Smtp-Source: AJdET5dATtw7ZmO4L3a3+WHp2aFUFrICbbWKfA3jkWEA4yH3sdy+5rrHmZcCFfMcZ7tWsvZV7n7iIw== X-Received: by 2002:a17:902:9f83:: with SMTP id g3-v6mr20118462plq.27.1540923812071; Tue, 30 Oct 2018 11:23:32 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c7-v6sm24805354pfh.25.2018.10.30.11.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 11:23:31 -0700 (PDT) Date: Tue, 30 Oct 2018 11:23:30 -0700 From: Guenter Roeck To: Geert Uytterhoeven Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , Jean Delvare , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-hwmon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: (ibmpowernv) Remove bogus __init annotations Message-ID: <20181030182330.GA25641@roeck-us.net> References: <20181028171651.30751-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181028171651.30751-1-geert@linux-m68k.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 28, 2018 at 06:16:51PM +0100, Geert Uytterhoeven wrote: > If gcc decides not to inline make_sensor_label(): > > WARNING: vmlinux.o(.text+0x4df549c): Section mismatch in reference from the function .create_device_attrs() to the function .init.text:.make_sensor_label() > The function .create_device_attrs() references > the function __init .make_sensor_label(). > This is often because .create_device_attrs lacks a __init > annotation or the annotation of .make_sensor_label is wrong. > > As .probe() can be called after freeing of __init memory, all __init > annotiations in the driver are bogus, and should be removed. > > Signed-off-by: Geert Uytterhoeven Applied. Thanks, Guenter > --- > Compile-tested only. > --- > drivers/hwmon/ibmpowernv.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c > index 0ccca87f527191dc..293dd1c6c7b36ef2 100644 > --- a/drivers/hwmon/ibmpowernv.c > +++ b/drivers/hwmon/ibmpowernv.c > @@ -181,7 +181,7 @@ static ssize_t show_label(struct device *dev, struct device_attribute *devattr, > return sprintf(buf, "%s\n", sdata->label); > } > > -static int __init get_logical_cpu(int hwcpu) > +static int get_logical_cpu(int hwcpu) > { > int cpu; > > @@ -192,9 +192,8 @@ static int __init get_logical_cpu(int hwcpu) > return -ENOENT; > } > > -static void __init make_sensor_label(struct device_node *np, > - struct sensor_data *sdata, > - const char *label) > +static void make_sensor_label(struct device_node *np, > + struct sensor_data *sdata, const char *label) > { > u32 id; > size_t n;