From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Manjunath Patil <manjunath.b.patil@oracle.com>
Cc: <boris.ostrovsky@oracle.com>, <jgross@suse.com>,
<konrad.wilk@oracle.com>, <axboe@kernel.dk>,
<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path
Date: Wed, 31 Oct 2018 09:22:25 +0100 [thread overview]
Message-ID: <20181031082225.zp2cnrfuinpbilv5@mac.citrite.net> (raw)
In-Reply-To: <1540918161-31283-1-git-send-email-manjunath.b.patil@oracle.com>
On Tue, Oct 30, 2018 at 09:49:21AM -0700, Manjunath Patil wrote:
> info->nr_rings isn't adjusted in case of ENOMEM error from
> negotiate_mq(). This leads to kernel panic in error path.
>
> Typical call stack involving panic -
> #8 page_fault at ffffffff8175936f
> [exception RIP: blkif_free_ring+33]
> RIP: ffffffffa0149491 RSP: ffff8804f7673c08 RFLAGS: 00010292
> ...
> #9 blkif_free at ffffffffa0149aaa [xen_blkfront]
> #10 talk_to_blkback at ffffffffa014c8cd [xen_blkfront]
> #11 blkback_changed at ffffffffa014ea8b [xen_blkfront]
> #12 xenbus_otherend_changed at ffffffff81424670
> #13 backend_changed at ffffffff81426dc3
> #14 xenwatch_thread at ffffffff81422f29
> #15 kthread at ffffffff810abe6a
> #16 ret_from_fork at ffffffff81754078
>
> Cc: stable@vger.kernel.org
> Fixes: 7ed8ce1c5fc7 ("xen-blkfront: move negotiate_mq to cover all cases of new VBDs")
> Signed-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2018-10-31 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 16:49 [PATCH v2] xen-blkfront: fix kernel panic with negotiate_mq error path Manjunath Patil
2018-10-30 16:52 ` Juergen Gross
2018-10-31 8:22 ` Roger Pau Monné [this message]
2018-11-06 9:37 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031082225.zp2cnrfuinpbilv5@mac.citrite.net \
--to=roger.pau@citrix.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manjunath.b.patil@oracle.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).