From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove
Date: Wed, 31 Oct 2018 09:52:30 +0000 [thread overview]
Message-ID: <20181031095230.GK16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181030145549.GB2459@kunai>
On Tue, Oct 30, 2018 at 02:55:50PM +0000, Wolfram Sang wrote:
>
> > No, that's fine. Now I get this, and I totally agree with the approach:
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Thanks! If one of you could provide me with a Fixes tag (for this. or
> both patches?), that would be most helpful.
>
It's a bit of a long chain and fairly tricky to say exactly when
the bug was introduced but I think this is probably the closest
match:
Fixes: 2fd36c552649 ("i2c: core: Map OF IRQ at probe time")
I suspect the process of unbinding/rebinding would have also
not worked before that commit but it would have not worked
for different reasons.
Thanks,
Charles
next prev parent reply other threads:[~2018-10-31 9:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 8:59 [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping Charles Keepax
2018-10-19 8:59 ` [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove Charles Keepax
2018-10-28 22:31 ` Wolfram Sang
2018-10-29 10:15 ` Benjamin Tissoires
2018-10-30 11:51 ` Charles Keepax
2018-10-30 14:34 ` Benjamin Tissoires
2018-10-30 14:55 ` Wolfram Sang
2018-10-31 9:52 ` Charles Keepax [this message]
2018-10-31 9:59 ` Wolfram Sang
2018-10-31 23:35 ` Wolfram Sang
2019-01-09 21:47 ` Yauhen Kharuzhy
2019-01-10 13:32 ` Charles Keepax
2019-01-10 20:35 ` Yauhen Kharuzhy
2018-10-28 22:30 ` [PATCH 1/2] i2c: Remove unnecessary call to irq_find_mapping Wolfram Sang
2018-10-29 10:13 ` Benjamin Tissoires
2018-10-31 23:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031095230.GK16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).