From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1F6ECDE44 for ; Wed, 31 Oct 2018 19:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C9ED20657 for ; Wed, 31 Oct 2018 19:15:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C9ED20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbeKAEPP (ORCPT ); Thu, 1 Nov 2018 00:15:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53892 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725731AbeKAEPO (ORCPT ); Thu, 1 Nov 2018 00:15:14 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 55BADA64; Wed, 31 Oct 2018 19:15:51 +0000 (UTC) Date: Wed, 31 Oct 2018 12:15:50 -0700 From: Andrew Morton To: Michal Hocko Cc: Dan Williams , Johannes Thumshirn , , LKML , Michal Hocko Subject: Re: [PATCH] memory_hotplug: cond_resched in __remove_pages Message-Id: <20181031121550.2f0cbd10a948880e534beaf7@linux-foundation.org> In-Reply-To: <20181031125840.23982-1-mhocko@kernel.org> References: <20181031125840.23982-1-mhocko@kernel.org> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 Oct 2018 13:58:40 +0100 Michal Hocko wrote: > From: Michal Hocko > > We have received a bug report that unbinding a large pmem (>1TB) > can result in a soft lockup: > > ... > > It has been reported on an older (4.12) kernel but the current upstream > code doesn't cond_resched in the hot remove code at all and the given > range to remove might be really large. Fix the issue by calling cond_resched > once per memory section. > Worthy of a cc:stable, I suggest?