From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org
Cc: boris.ostrovsky@oracle.com, jgross@suse.com, bhe@redhat.com,
willy@infradead.org, x86@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/3] x86/ldt: Unmap PTEs for the slot before freeing LDT pages
Date: Wed, 31 Oct 2018 15:17:59 +0300 [thread overview]
Message-ID: <20181031121758.wrxidqhkvegfh7h7@black.fi.intel.com> (raw)
In-Reply-To: <20181026122856.66224-3-kirill.shutemov@linux.intel.com>
On Fri, Oct 26, 2018 at 12:28:55PM +0000, Kirill A. Shutemov wrote:
> + va = (unsigned long)ldt_slot_va(ldt->slot);
> + flush_tlb_mm_range(mm, va, va + nr_pages * PAGE_SIZE, 0, false);
I've got it wrong on rebase. It has to be PAGE_SHIFT instead of 0.
Here's the fix up.
diff --git a/arch/x86/kernel/ldt.c b/arch/x86/kernel/ldt.c
index 5dc8ed202fa8..60775dcd5bcc 100644
--- a/arch/x86/kernel/ldt.c
+++ b/arch/x86/kernel/ldt.c
@@ -287,7 +287,7 @@ unmap_ldt_struct(struct mm_struct *mm, struct ldt_struct *ldt)
}
va = (unsigned long)ldt_slot_va(ldt->slot);
- flush_tlb_mm_range(mm, va, va + nr_pages * PAGE_SIZE, 0, false);
+ flush_tlb_mm_range(mm, va, va + nr_pages * PAGE_SIZE, PAGE_SHIFT, false);
}
#else /* !CONFIG_PAGE_TABLE_ISOLATION */
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-10-31 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 12:28 [PATCHv3 0/3] Fix couple of issues with LDT remap for PTI Kirill A. Shutemov
2018-10-26 12:28 ` [PATCHv3 1/3] x86/mm: Move LDT remap out of KASLR region on 5-level paging Kirill A. Shutemov
2018-11-02 21:07 ` Andy Lutomirski
2018-11-06 20:39 ` [tip:x86/urgent] " tip-bot for Kirill A. Shutemov
2018-11-10 12:29 ` [PATCHv3 1/3] " Baoquan He
2018-11-23 15:58 ` Kirill A. Shutemov
2018-12-03 3:01 ` Baoquan He
2018-12-03 9:26 ` Kirill A. Shutemov
2018-10-26 12:28 ` [PATCHv3 2/3] x86/ldt: Unmap PTEs for the slot before freeing LDT pages Kirill A. Shutemov
2018-10-31 12:17 ` Kirill A. Shutemov [this message]
2018-11-06 20:40 ` [tip:x86/urgent] " tip-bot for Kirill A. Shutemov
2018-10-26 12:28 ` [PATCHv3 3/3] x86/ldt: Remove unused variable in map_ldt_struct() Kirill A. Shutemov
2018-11-02 21:08 ` Andy Lutomirski
2018-11-06 20:40 ` [tip:x86/urgent] " tip-bot for Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031121758.wrxidqhkvegfh7h7@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).