From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH 4.18] Revert "mm: slowly shrink slabs with a relatively small number of objects"
Date: Wed, 31 Oct 2018 09:52:42 -0400 [thread overview]
Message-ID: <20181031135242.GI194472@sasha-vm> (raw)
In-Reply-To: <20181026111859.23807-1-sashal@kernel.org>
On Fri, Oct 26, 2018 at 07:18:59AM -0400, Sasha Levin wrote:
>This reverts commit 62aad93f09c1952ede86405894df1b22012fd5ab.
>
>Which was upstream commit 172b06c32b94 ("mm: slowly shrink slabs with a
>relatively small number of objects").
>
>The upstream commit was found to cause regressions. While there is a
>proposed fix upstream, revent this patch from stable trees for now as
>testing the fix will take some time.
>
>Signed-off-by: Sasha Levin <sashal@kernel.org>
>---
> mm/vmscan.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index fc0436407471..03822f86f288 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -386,17 +386,6 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl,
> delta = freeable >> priority;
> delta *= 4;
> do_div(delta, shrinker->seeks);
>-
>- /*
>- * Make sure we apply some minimal pressure on default priority
>- * even on small cgroups. Stale objects are not only consuming memory
>- * by themselves, but can also hold a reference to a dying cgroup,
>- * preventing it from being reclaimed. A dying cgroup with all
>- * corresponding structures like per-cpu stats and kmem caches
>- * can be really big, so it may lead to a significant waste of memory.
>- */
>- delta = max_t(unsigned long long, delta, min(freeable, batch_size));
>-
> total_scan += delta;
> if (total_scan < 0) {
> pr_err("shrink_slab: %pF negative objects to delete nr=%ld\n",
I've queued it up for 4.18.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-10-31 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 11:18 [PATCH 4.18] Revert "mm: slowly shrink slabs with a relatively small number of objects" Sasha Levin
2018-10-31 13:52 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031135242.GI194472@sasha-vm \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).