From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6444C0044C for ; Wed, 31 Oct 2018 19:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1D482080A for ; Wed, 31 Oct 2018 19:28:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1D482080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728128AbeKAE2V (ORCPT ); Thu, 1 Nov 2018 00:28:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbeKAE2V (ORCPT ); Thu, 1 Nov 2018 00:28:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0CF830832D2; Wed, 31 Oct 2018 19:28:55 +0000 (UTC) Received: from sandy.ghostprotocols.net (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E51A600C0; Wed, 31 Oct 2018 19:28:55 +0000 (UTC) Received: by sandy.ghostprotocols.net (Postfix, from userid 1000) id 03CEA43FC; Wed, 31 Oct 2018 17:28:52 -0200 (BRST) Date: Wed, 31 Oct 2018 17:28:52 -0200 From: Arnaldo Carvalho de Melo To: Takashi Iwai Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Jiri Olsa , Namhyung Kim , Takashi Sakamoto Subject: Re: [PATCH 17/28] tools include uapi: Update asound.h copy Message-ID: <20181031192852.GD6669@redhat.com> References: <20181031164508.4784-1-acme@kernel.org> <20181031164508.4784-18-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 31 Oct 2018 19:28:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 31, 2018 at 06:00:47PM +0100, Takashi Iwai escreveu: > On Wed, 31 Oct 2018 17:44:57 +0100, > Arnaldo Carvalho de Melo wrote: > > > > From: Arnaldo Carvalho de Melo > > > > To silence this perf build warning: > > > > Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h' > > diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h > > > > Due to this cset: > > > > a98401518def ("ALSA: timer: fix wrong comment to refer to 'SNDRV_TIMER_PSFLG_*'") > > > > Cc: Jiri Olsa > > Cc: Namhyung Kim > > Cc: Takashi Sakamoto > > Cc: Takashi Iwai > > Link: https://lkml.kernel.org/n/tip-76gsvs0w2g0x723ivqa2xua3@git.kernel.org > > Signed-off-by: Arnaldo Carvalho de Melo > > Thanks for the correction. > > That's bad to have duped files that have to be synced manually... There is an advantage, we get warnings about changes that could entail changes in the tools, also it has happened in the past that changes made in the kernel end up breaking the tools/ build, so the synch should be done carefully. Also we don't want to add to the workload of kernel developers. > At least, some checkpatch addition would help to suggest always > correct both places? I think not having it is better. - Arnaldo