From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051FEECDE44 for ; Wed, 31 Oct 2018 23:35:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C80CF20664 for ; Wed, 31 Oct 2018 23:35:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C80CF20664 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730602AbeKAIf0 (ORCPT ); Thu, 1 Nov 2018 04:35:26 -0400 Received: from sauhun.de ([88.99.104.3]:59796 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728699AbeKAIf0 (ORCPT ); Thu, 1 Nov 2018 04:35:26 -0400 Received: from localhost (unknown [87.114.85.207]) by pokefinder.org (Postfix) with ESMTPSA id 529682E35EA; Thu, 1 Nov 2018 00:35:04 +0100 (CET) Date: Wed, 31 Oct 2018 23:35:02 +0000 From: Wolfram Sang To: Charles Keepax Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove Message-ID: <20181031233502.GB8321@kunai> References: <20181019085958.32694-1-ckeepax@opensource.cirrus.com> <20181019085958.32694-2-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <20181019085958.32694-2-ckeepax@opensource.cirrus.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 19, 2018 at 09:59:58AM +0100, Charles Keepax wrote: > The IRQ will be mapped in i2c_device_probe only if client->irq is zero and > i2c_device_remove does not clear this. When rebinding an I2C device, > whos IRQ provider has also been rebound this means that an IRQ mapping > will never be created, causing the I2C device to fail to acquire its > IRQ. Fix this issue by clearing client->irq in i2c_device_remove, > forcing i2c_device_probe to lookup the mapping again. >=20 > Signed-off-by: Charles Keepax Applied to for-current, thanks! --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlvaPCYACgkQFA3kzBSg KbagKA/9FcmeFpRbTCBZSnQ0ei127fILessOcNaMqJhi386/lKyF87/Wo7MbuYnw 5lbtxe16L40Mt0tvdbT/Q1K5FUJ6OerTGz3NwJeiQJhAkQxCbHdc+w9bByMbwyqi 18f4q/PgBqpiUsIwu5HzXJLfZyVdhX5/m1uvG+Gi+pwIRk7yx5bbuZpx5pIDUtN1 2Bi6+pmQhDMbHIGQTo3fw6MHax/FX0aQ70WJ64o/2g2Apa+IynbksZvjkdq5Cc8W /GikRRPSN7Ngx0xJUyQ2YP1Ct/LX4de0uLre9eWqnATvZTrRk/puXQWvAm3ywz8X JVNbwFdYFVxUCk12W4d/5uWw37R6Ah+diav8W7KsPzoNhCvmRFkSq5ROpyVXzlZ4 rhFsa5uoNqN6x5lUMpkfWFeNHaS3NPTWnCcLw8fb7ZBe0vyc5riWGb0Kr9hU86fC UKHhgh1eEynn/WIOLNKQMADn4qjc9H9wQg2IqhXO8z/CIp8b6c2fT1QE3mnKH7VA QWcX2jdYzEDIOK67sy4HlSMJ0gm+RXPdq9JLHN0nvrpoLDSbrqx75P0jbptOXUrE rB6dPJV6/lMCAwCq6ZcHU5wkTQGoPmXrLq8Mu3VDMigac3DyRKNM10/81/QMcRO7 6xdGQX9BKDe7bJFDIgQ5+BPoewa2luHv7qpnlA2WZrk76CFFmwk= =Aof/ -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--