linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: arndb@arndb.de, Florian Fainelli <f.fainelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Nishanth Menon <nm@ti.com>,
	Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Michael Moese <mmoese@suse.de>, Lokesh Vutla <lokeshvutla@ti.com>,
	linux-serial@vger.kernel.org (open list:SERIAL DRIVERS)
Subject: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250
Date: Thu,  1 Nov 2018 11:26:06 -0700	[thread overview]
Message-ID: <20181101182609.24142-1-f.fainelli@gmail.com> (raw)

It is way too easy to miss enabling SERIAL_OF_PLATFORM which would
result in the inability for the kernel to have a valid console device,
which can be seen with:

Warning: unable to open an initial console.

and then:

Run /init as init process
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000100

Since SERIAL_OF_PLATFORM already depends on SERIAL_8250 && OF there
really is no drawback to defaulting this config to the value of
SERIAL_8250.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/tty/serial/8250/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 15c2c5463835..d7737dca0e48 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -484,6 +484,7 @@ config SERIAL_8250_PXA
 config SERIAL_OF_PLATFORM
 	tristate "Devicetree based probing for 8250 ports"
 	depends on SERIAL_8250 && OF
+	default SERIAL_8250
 	help
 	  This option is used for all 8250 compatible serial ports that
 	  are probed through devicetree, including Open Firmware based
-- 
2.17.1


             reply	other threads:[~2018-11-01 18:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 18:26 Florian Fainelli [this message]
2018-11-15  1:11 Guenter Roeck
2018-11-15  3:56 ` Florian Fainelli
2018-11-15  5:36   ` Guenter Roeck
2018-11-15 17:19     ` Florian Fainelli
2018-11-15  5:38   ` Guenter Roeck
2018-11-15 17:19     ` Florian Fainelli
2018-11-15 17:25       ` Guenter Roeck
2018-11-15 19:48         ` Florian Fainelli
2018-11-16  1:16           ` Guenter Roeck
2018-11-19 18:44             ` Florian Fainelli
2018-11-19 20:50               ` Guenter Roeck
2018-11-23 18:20                 ` Guenter Roeck
2018-11-27  0:08                   ` Florian Fainelli
2018-12-05  5:47                     ` Michael Ellerman
2018-12-05 22:40                       ` Florian Fainelli
2018-12-20 15:21 ` Greg Kroah-Hartman
2018-12-20 17:38   ` Guenter Roeck
2018-12-21  4:28     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181101182609.24142-1-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=arndb@arndb.de \
    --cc=borntraeger@de.ibm.com \
    --cc=brueckner@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=mmoese@suse.de \
    --cc=nm@ti.com \
    --subject='Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox