From: Christoffer Dall <christoffer.dall@arm.com>
To: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andrew Jones <drjones@redhat.com>,
Dave Martin <Dave.Martin@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
kvmarm@lists.cs.columbia.edu,
Kristina Martsenko <kristina.martsenko@arm.com>,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 6/7] arm64: docs: document KVM support of pointer authentication
Date: Fri, 2 Nov 2018 09:39:39 +0100 [thread overview]
Message-ID: <20181102083939.GW12057@e113682-lin.lund.arm.com> (raw)
In-Reply-To: <1539773280-4159-7-git-send-email-amit.kachhap@arm.com>
On Wed, Oct 17, 2018 at 04:17:59PM +0530, Amit Daniel Kachhap wrote:
> The documentation is updated to help in using pointer authentication
> for KVM guests.
>
> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Christoffer Dall <christoffer.dall@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: kvmarm@lists.cs.columbia.edu
> ---
> Documentation/arm64/pointer-authentication.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/arm64/pointer-authentication.txt b/Documentation/arm64/pointer-authentication.txt
> index 8a9cb57..b00d735 100644
> --- a/Documentation/arm64/pointer-authentication.txt
> +++ b/Documentation/arm64/pointer-authentication.txt
> @@ -78,7 +78,13 @@ to TTBR1 addresses (e.g. kernel pointers).
> Virtualization
> --------------
>
> -Pointer authentication is not currently supported in KVM guests. KVM
> +Pointer authentication is enabled in KVM guest when virtual machine is
> +created by passing a flag requesting this feature to be enabled. Without
> +this flag, pointer authentication is not enabled in KVM guests and KVM
> will mask the feature bits from ID_AA64ISAR1_EL1, and attempted use of
> the feature will result in an UNDEFINED exception being injected into
> the guest.
> +
> +The flag to enable this feature is KVM_ARM_VCPU_PTRAUTH and should be
> +used in KVM API KVM_ARM_VCPU_INIT. The pointer authentication key
> +registers are hidden from userspace if this feature is not enabled.
> --
> 2.7.4
>
I think this is placed in the wrong file.
Any information about the KVM API should go in
Documentation/virtual/kvm/api.txt.
The only information about KVM that belongs in this file would be host
running a VM with ptrauth can affect the host's ptrauth state (if that
applies).
Thanks,
Christoffer
next prev parent reply other threads:[~2018-11-02 8:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:47 [PATCH v3 0/7] Add ARMv8.3 pointer authentication for kvm guest Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 1/7] arm64/kvm: preserve host HCR_EL2 value Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 2/7] arm64/kvm: context-switch ptrauth registers Amit Daniel Kachhap
2018-11-02 8:37 ` Christoffer Dall
2018-11-12 22:32 ` Catalin Marinas
2018-11-13 13:44 ` Christoffer Dall
2018-11-15 14:33 ` Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 3/7] arm64/kvm: add a userspace option to enable pointer authentication Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 4/7] arm64/kvm: enable pointer authentication cpufeature conditionally Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 5/7] arm64/kvm: control accessibility of ptrauth key registers Amit Daniel Kachhap
2018-10-17 10:47 ` [PATCH v3 6/7] arm64: docs: document KVM support of pointer authentication Amit Daniel Kachhap
2018-11-02 8:39 ` Christoffer Dall [this message]
2018-10-17 10:48 ` [PATCH v3 7/7] arm/kvm: arm64: Add a vcpu feature for " Amit Daniel Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102083939.GW12057@e113682-lin.lund.arm.com \
--to=christoffer.dall@arm.com \
--cc=Dave.Martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).