From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973C5C32789 for ; Fri, 2 Nov 2018 18:10:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E1392082E for ; Fri, 2 Nov 2018 18:10:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JlUg71d7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E1392082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbeKCDSJ (ORCPT ); Fri, 2 Nov 2018 23:18:09 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:34936 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727747AbeKCDSJ (ORCPT ); Fri, 2 Nov 2018 23:18:09 -0400 Received: by mail-pf1-f195.google.com with SMTP id z2-v6so1384835pfe.2 for ; Fri, 02 Nov 2018 11:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Lat4TpCI71/3cxlaRQGsbFWbxSR9AgcpXz1+oAxrm0Y=; b=JlUg71d78M20dRhF3abONh16OyZZ6hGn10nWoVIYrTs+kloTHIlkB0hYXV8ABn8HUf +jxdSSL58CyFJwoxJNDmfezndYtMYuQAoS17Bi/8F+n7Z9ssA7Mgoq+VRO4OsowfNzBe oBh/WxW9lZxW8cx5gr9YNiUnao6X5xZCjb/mA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Lat4TpCI71/3cxlaRQGsbFWbxSR9AgcpXz1+oAxrm0Y=; b=DcWPV018ODSuPzdKMFFowysYy0k0RdHZ6555YhdlT3SaBYi2D1CkVoTLQzKQtepCDO pPndQR7AG9E2x1yVGGM7YRf9qZfhkzL9iWxzk8MyVTzHkaEPGRS5ndWtAxOTZfjQ6uem /aNafM8MacMB1ESZaKNlLHZJVPmcqNOLvtdxExOQScxcSnMtWA0JRnjQ7FkeNAQ7KmKg u+OPlCjli3wqq1q81NP9Q7ayrecbYsVn+jMWgpKyi02GOZrKiubSjCjnwISBMUzphWQY 9xp5FTsDlrDs3cwdEbJ9/nsiSGFlb6gLr4B6hneWZM+vWDP+WHn8rYmHriZGfxBsw4PK 4Lqg== X-Gm-Message-State: AGRZ1gKOaK0RPeV0926+7sUSSgo5C+APlyCs9tk+Fch+9yetgWQOKUgd XyPUnn215ghXIfEO9pnnQ1u/kQ== X-Google-Smtp-Source: AJdET5ear+DAfnKHu+mWQJNUvZpDYVCwlDRtBn9YycyQ46lvtEQp7LcrAAuB20DtGnLzCei0Bm7/KA== X-Received: by 2002:a63:4e41:: with SMTP id o1mr12084835pgl.282.1541182205540; Fri, 02 Nov 2018 11:10:05 -0700 (PDT) Received: from smtp.gmail.com ([2620:15c:202:1:299d:6b87:5478:d28a]) by smtp.gmail.com with ESMTPSA id y184sm2416357pgd.71.2018.11.02.11.10.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 11:10:03 -0700 (PDT) From: Brian Norris To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, , Brian Norris Subject: [PATCH] ath10k: ath10k_snoc_{read,write}32() should be static Date: Fri, 2 Nov 2018 11:10:00 -0700 Message-Id: <20181102181000.96834-1-briannorris@chromium.org> X-Mailer: git-send-email 2.19.1.930.g4563a0d9d0-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org They're provided as callbacks in ath10k_hif_ops and should be accessed that way, if needed outside of snoc.c, and anyway, they're currently unused outside snoc.c. Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/snoc.c | 4 ++-- drivers/net/wireless/ath/ath10k/snoc.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index ffdebf9a5ac6..5b37a0c68be6 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -474,14 +474,14 @@ static struct service_to_pipe target_service_to_ce_map_wlan[] = { }, }; -void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value) +static void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); iowrite32(value, ar_snoc->mem + offset); } -u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset) +static u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); u32 val; diff --git a/drivers/net/wireless/ath/ath10k/snoc.h b/drivers/net/wireless/ath/ath10k/snoc.h index e1d2d6675556..de077bc8bc74 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.h +++ b/drivers/net/wireless/ath/ath10k/snoc.h @@ -91,8 +91,6 @@ static inline struct ath10k_snoc *ath10k_snoc_priv(struct ath10k *ar) return (struct ath10k_snoc *)ar->drv_priv; } -void ath10k_snoc_write32(struct ath10k *ar, u32 offset, u32 value); -u32 ath10k_snoc_read32(struct ath10k *ar, u32 offset); int ath10k_snoc_fw_indication(struct ath10k *ar, u64 type); #endif /* _SNOC_H_ */ -- 2.19.1.930.g4563a0d9d0-goog