From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: pshelar@ovn.org, pablo@netfilter.org, fw@strlen.de,
fbl@redhat.com, gfree.wind@vip.163.com, thierry@dtsystems.be,
yihung.wei@gmail.com, eswierk@skyportsystems.com,
Julia.Lawall@lip6.fr, netdev@vger.kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openvswitch: fix linking without CONFIG_NF_CONNTRACK_LABELS
Date: Sat, 03 Nov 2018 19:29:00 -0700 (PDT) [thread overview]
Message-ID: <20181103.192900.1832032988138355597.davem@davemloft.net> (raw)
In-Reply-To: <20181102153705.1664786-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 2 Nov 2018 16:36:55 +0100
> When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is enabled, the compiler
> fails to optimize out a dead code path, which leads to a link failure:
>
> net/openvswitch/conntrack.o: In function `ovs_ct_set_labels':
> conntrack.c:(.text+0x2e60): undefined reference to `nf_connlabels_replace'
>
> In this configuration, we can take a shortcut, and completely
> remove the contrack label code. This may also help the regular
> optimization.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
prev parent reply other threads:[~2018-11-04 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 15:36 [PATCH] openvswitch: fix linking without CONFIG_NF_CONNTRACK_LABELS Arnd Bergmann
2018-11-04 2:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181103.192900.1832032988138355597.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Julia.Lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=dev@openvswitch.org \
--cc=eswierk@skyportsystems.com \
--cc=fbl@redhat.com \
--cc=fw@strlen.de \
--cc=gfree.wind@vip.163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pshelar@ovn.org \
--cc=thierry@dtsystems.be \
--cc=yihung.wei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).