From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC6FC0044C for ; Sat, 3 Nov 2018 19:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 305162084A for ; Sat, 3 Nov 2018 19:05:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 305162084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbeKDERe (ORCPT ); Sun, 4 Nov 2018 00:17:34 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:42747 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbeKDERe (ORCPT ); Sun, 4 Nov 2018 00:17:34 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5D29980938; Sat, 3 Nov 2018 20:05:22 +0100 (CET) Date: Sat, 3 Nov 2018 20:05:24 +0100 From: Pavel Machek To: Lubomir Rintel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Eric Miao , Haojian Zhuang , Rob Herring , Mark Rutland Subject: Re: [PATCH 1/2] DT: marvell,mmp2: fix TWSI2 Message-ID: <20181103190524.GC31179@amd> References: <20180917113947.12626-1-lkundrak@v3.sk> <20180917113947.12626-2-lkundrak@v3.sk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/Uq4LBwYP4y1W6pO" Content-Disposition: inline In-Reply-To: <20180917113947.12626-2-lkundrak@v3.sk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/Uq4LBwYP4y1W6pO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2018-09-17 13:39:46, Lubomir Rintel wrote: > Marvell keeps their MMP2 datasheet secret, but there are good clues > that TWSI2 is not on 0xd4025000 on that platform, not does it use > IRQ 58. In fact, the IRQ 58 on MMP2 seems to be a signal processor: >=20 > arch/arm/mach-mmp/irqs.h:#define IRQ_MMP2_MSP 58 >=20 > I'm taking a somewhat educated guess that is probably a copy & paste > error from PXA168 or PXA910 and that the real controller in fact hides > at address 0xd4031000 and uses an interrupt line multiplexed via IRQ 17. >=20 > I'm also copying some properties from TWSI1 that were missing or > incorrect. >=20 > Tested on a OLPC XO 1.75 machine, where the RTC is on TWSI2. >=20 > Cc: Eric Miao > Cc: Haojian Zhuang > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > status =3D "disabled"; > }; > =20 > - twsi2: i2c@d4025000 { > + twsi2: i2c@d4031000 { > compatible =3D "mrvl,mmp-twsi"; > - reg =3D <0xd4025000 0x1000>; > - interrupts =3D <58>; > + reg =3D <0xd4031000 0x1000>; > + interrupt-parent =3D <&intcmux17>; > + interrupts =3D <0>; > clocks =3D <&soc_clocks MMP2_CLK_TWSI1>; > resets =3D <&soc_clocks MMP2_CLK_TWSI1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > status =3D "disabled"; > }; > =20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --/Uq4LBwYP4y1W6pO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvd8XQACgkQMOfwapXb+vKSjACgv6Lkz3rRh4XiylK+HXaqmWqA 3/IAnjQOUO+mZ4PAESNh8Oe7MPWYRAGL =YgrZ -----END PGP SIGNATURE----- --/Uq4LBwYP4y1W6pO--