From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Maninder Singh <maninder1.s@samsung.com>,
Matteo Croce <mcroce@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bloat-o-meter: ignore __addressable_ symbols
Date: Mon, 5 Nov 2018 16:40:27 +0200 [thread overview]
Message-ID: <20181105144027.GM10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181102210030.8383-1-linux@rasmusvillemoes.dk>
On Fri, Nov 02, 2018 at 10:00:25PM +0100, Rasmus Villemoes wrote:
> Since __LINE__ is part of the symbol created by __ADDRESSABLE, almost
> any change causes those symbols to disappear and get reincarnated, e.g.
>
> add/remove: 4/4 grow/shrink: 0/3 up/down: 32/-171 (-139)
> Function old new delta
> __addressable_tracing_set_default_clock8649 - 8 +8
> __addressable_tracer_init_tracefs8631 - 8 +8
> __addressable_ftrace_dump8383 - 8 +8
> __addressable_clear_boot_tracer8632 - 8 +8
> __addressable_tracing_set_default_clock8650 8 - -8
> __addressable_tracer_init_tracefs8632 8 - -8
> __addressable_ftrace_dump8384 8 - -8
> __addressable_clear_boot_tracer8633 8 - -8
> trace_default_header 663 642 -21
> tracing_mark_raw_write 406 355 -51
> tracing_mark_write 624 557 -67
> Total: Before=63889, After=63750, chg -0.22%
>
> They're small and in .discard, so ignore them, leading to more useful
>
> add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-139 (-139)
> Function old new delta
> trace_default_header 663 642 -21
> tracing_mark_raw_write 406 355 -51
> tracing_mark_write 624 557 -67
> Total: Before=63721, After=63582, chg -0.22%
Useful!
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> scripts/bloat-o-meter | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
> index a923f05edb36..8c965f6a9881 100755
> --- a/scripts/bloat-o-meter
> +++ b/scripts/bloat-o-meter
> @@ -32,6 +32,7 @@ def getsizes(file, format):
> if name.startswith("__mod_"): continue
> if name.startswith("__se_sys"): continue
> if name.startswith("__se_compat_sys"): continue
> + if name.startswith("__addressable_"): continue
> if name == "linux_banner": continue
> # statics and some other optimizations adds random .NUMBER
> name = re_NUMBER.sub('', name)
> --
> 2.19.1.6.gbde171bbf5
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-11-05 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 21:00 [PATCH] bloat-o-meter: ignore __addressable_ symbols Rasmus Villemoes
2018-11-05 14:40 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105144027.GM10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@rasmusvillemoes.dk \
--cc=maninder1.s@samsung.com \
--cc=mcroce@redhat.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).