* [PATCH] f2fs: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-11-05 14:41 Yangtao Li
2018-11-06 9:12 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-11-05 14:41 UTC (permalink / raw)
To: jaegeuk, yuchao0; +Cc: linux-f2fs-devel, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
fs/f2fs/debug.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index 214a968962a1..ef827c0d0379 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -428,18 +428,7 @@ static int stat_show(struct seq_file *s, void *v)
return 0;
}
-static int stat_open(struct inode *inode, struct file *file)
-{
- return single_open(file, stat_show, inode->i_private);
-}
-
-static const struct file_operations stat_fops = {
- .owner = THIS_MODULE,
- .open = stat_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(stat);
int f2fs_build_stats(struct f2fs_sb_info *sbi)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-11-05 14:41 [PATCH] f2fs: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-11-06 9:12 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-11-06 9:12 UTC (permalink / raw)
To: Yangtao Li, jaegeuk; +Cc: linux-f2fs-devel, linux-kernel
On 2018/11/5 22:41, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-06 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 14:41 [PATCH] f2fs: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-11-06 9:12 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).