linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org, shai@scalemp.com, jgross@suse.com,
	eial@scalemp.com, hpa@zytor.com, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops
Date: Mon, 5 Nov 2018 16:41:39 +0100	[thread overview]
Message-ID: <20181105154139.GA124398@gmail.com> (raw)
In-Reply-To: <tip-7f2d7f8190d856949d8aaab55d3902cd10ea1048@git.kernel.org>


* tip-bot for Eial Czerwacki <tipbot@zytor.com> wrote:

> Commit-ID:  7f2d7f8190d856949d8aaab55d3902cd10ea1048
> Gitweb:     https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
> Author:     Eial Czerwacki <eial@scalemp.com>
> AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
> 
> x86/vsmp: Remove dependency on pv_irq_ops
> 
> vsmp dependency on pv_irq_ops has been removed some years ago, but the code
> still deals with pv_irq_ops.

s/vsmp
 /vSMP

> +#if defined CONFIG_PCI

I don't think code was ever tested with PCI disabled?

The above typoed sequence of code accidentally evaluates to 'true' 
regardless of CONFIG_PCI.

Thanks,

	Ingo

  reply	other threads:[~2018-11-05 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  8:01 [PATCH] x86/vsmp: Remove dependency on pv_irq_ops Eial Czerwacki
2018-11-05 11:36 ` [tip:x86/urgent] " tip-bot for Eial Czerwacki
2018-11-05 15:41   ` Ingo Molnar [this message]
2018-11-05 15:44     ` Thomas Gleixner
2018-11-05 16:40       ` Eial Czerwacki
2018-11-05 17:31 [PATCH v3] x86/vsmp_64.c: " Eial Czerwacki
2018-11-06 20:41 ` [tip:x86/urgent] x86/vsmp: " tip-bot for Eial Czerwacki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105154139.GA124398@gmail.com \
    --to=mingo@kernel.org \
    --cc=eial@scalemp.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=shai@scalemp.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).