From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69664C46475 for ; Mon, 5 Nov 2018 17:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39EC520862 for ; Mon, 5 Nov 2018 17:13:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39EC520862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387573AbeKFCeS (ORCPT ); Mon, 5 Nov 2018 21:34:18 -0500 Received: from mga06.intel.com ([134.134.136.31]:14534 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729775AbeKFCeS (ORCPT ); Mon, 5 Nov 2018 21:34:18 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 09:13:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,468,1534834800"; d="scan'208";a="271539054" Received: from wenjiewa-mobl2.ccr.corp.intel.com (HELO localhost) ([10.249.254.60]) by orsmga005.jf.intel.com with ESMTP; 05 Nov 2018 09:13:35 -0800 Date: Mon, 5 Nov 2018 19:13:34 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: Mimi Zohar , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v3 4/5] tpm: retrieve digest size of unknown algorithms with PCR read Message-ID: <20181105171334.GB4502@linux.intel.com> References: <20181030154711.2782-1-roberto.sassu@huawei.com> <20181030154711.2782-5-roberto.sassu@huawei.com> <1541088173.4035.26.camel@linux.ibm.com> <3034c896-788b-50f9-23cb-f4b2cd6363e6@huawei.com> <20181105120147.GA7621@linux.intel.com> <3b198ce9-9e2e-5290-bd40-e9a62da1f50d@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b198ce9-9e2e-5290-bd40-e9a62da1f50d@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 05, 2018 at 02:09:12PM +0100, Roberto Sassu wrote: > On 11/5/2018 1:01 PM, Jarkko Sakkinen wrote: > > On Mon, Nov 05, 2018 at 10:47:19AM +0100, Roberto Sassu wrote: > > > > Commit 1db15344f874 ("tpm: implement TPM 2.0 capability to get active > > > > PCR banks") defined active_banks[7].  Subsequently, commit > > > > 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event > > > > log") defined TPM2_PCR_ACTIVE_BANKS as 3.  I'm not sure which is the > > > > correct value, but the number of active_banks should not be hard coded > > > > here. > > > > > > Jarkko, should I change the value of TPM2_PCR_ACTIVE_BANKS, or set the > > > size of the active_banks array to TPM2_PCR_ACTIVE_BANKS? > > > > Hi, sorry I missed your patch set. Please add me either to 'To' or 'Cc' > > field of the email if you want a quick response. > > > > I think the implementation is flakky in both places and should be fixed > > before doing any other changes. Thanks James for pointing out these > > commits. > > > > What you need to do is to create a prequel commit that reads the number > > of banks to a variable e.g. > > > > unsigned int nr_active_banks; > > > > and allocate 'active_banks' dynamically and change the places that > > James pointed out. I guess it is OK to have a commit with two 'Fixes' > > tags. > > Ok, then I can remove patch 1/5 if nr_active_banks is included in the > tpm_chip structure. > > Roberto Yeah, I think it would be appropriate to have two fixes tags albeit it is arguable whether those are regressions (probably not, I guess inconsistency would be a better word) but I don't think they need to be cc'd to stable@vger.kernel.org. /Jarkko