* linux-next: Signed-off-by missing for commit in the xtensa tree
@ 2018-11-05 23:08 Stephen Rothwell
2018-11-05 23:14 ` Max Filippov
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2018-11-05 23:08 UTC (permalink / raw)
To: Max Filippov; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
Hi Max,
Commit
12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
is missing a Signed-off-by from its author and committer.
Reverts are commits too.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the xtensa tree
2018-11-05 23:08 linux-next: Signed-off-by missing for commit in the xtensa tree Stephen Rothwell
@ 2018-11-05 23:14 ` Max Filippov
2018-11-05 23:19 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Max Filippov @ 2018-11-05 23:14 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux-Next, LKML
Hi Stephen,
On Mon, Nov 5, 2018 at 3:09 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Commit
>
> 12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
>
> is missing a Signed-off-by from its author and committer.
>
> Reverts are commits too.
Thanks for catching that. Should I rewrite that branch fixing up that commit?
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the xtensa tree
2018-11-05 23:14 ` Max Filippov
@ 2018-11-05 23:19 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2018-11-05 23:19 UTC (permalink / raw)
To: Max Filippov; +Cc: Linux-Next, LKML
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Hi Max,
On Mon, 5 Nov 2018 15:14:44 -0800 Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> On Mon, Nov 5, 2018 at 3:09 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Commit
> >
> > 12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
> >
> > is missing a Signed-off-by from its author and committer.
> >
> > Reverts are commits too.
>
> Thanks for catching that. Should I rewrite that branch fixing up that commit?
There is nothing else you can do. The only reason not to is if you
strictly do not rebase your branch (or there has been lots of other
activity - which there is not in this case).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-05 23:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-05 23:08 linux-next: Signed-off-by missing for commit in the xtensa tree Stephen Rothwell
2018-11-05 23:14 ` Max Filippov
2018-11-05 23:19 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).