From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Sean Christopherson" <sean.j.christopherson@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Oded Gabbay" <oded.gabbay@amd.com>
Subject: Re: [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier()
Date: Tue, 6 Nov 2018 14:26:32 +0100 [thread overview]
Message-ID: <20181106132632.GD2453@dhcp22.suse.cz> (raw)
In-Reply-To: <20181105121833.200d5b53300a7ef4df7d349d@linux-foundation.org>
On Mon 05-11-18 12:18:33, Andrew Morton wrote:
> On Mon, 5 Nov 2018 11:29:55 -0800 Sean Christopherson <sean.j.christopherson@intel.com> wrote:
[...]
> > -EXPORT_SYMBOL_GPL(mmu_notifier_synchronize);
> > +EXPORT_SYMBOL_GPL(mmu_notifier_barrier);
> >
> > /*
> > * This function can't run concurrently against mmu_notifier_register
>
> But as it has no callers, why retain it?
Exported symbols are not freed and if this is not used by any in-kernel
code then I would just remove it.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-11-06 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 19:29 [PATCH] mm/mmu_notifier: rename mmu_notifier_synchronize() to <...>_barrier() Sean Christopherson
2018-11-05 20:18 ` Andrew Morton
2018-11-05 20:49 ` Sean Christopherson
2018-11-05 21:14 ` Matthew Wilcox
2018-11-06 13:34 ` Sean Christopherson
2018-11-06 13:26 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106132632.GD2453@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oded.gabbay@amd.com \
--cc=peterz@infradead.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).