From: Hans Holmberg <hans.ml.holmberg@owltronix.com>
To: Matias Bjorling <mb@lightnvm.io>
Cc: Javier Gonzales <javier@cnexlabs.com>,
Sebastien Boisvert <sboisvert@gydle.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: [PATCH v3 7/7] lightnvm: pblk: remove dead code in pblk_recov_l2p
Date: Tue, 6 Nov 2018 14:33:30 +0100 [thread overview]
Message-ID: <20181106133330.26570-8-hans.ml.holmberg@owltronix.com> (raw)
In-Reply-To: <20181106133330.26570-1-hans.ml.holmberg@owltronix.com>
From: Hans Holmberg <hans.holmberg@cnexlabs.com>
Remove the call to pblk_line_replace_data as it returns
directly because we have not set l_mg->data_next yet.
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
---
drivers/lightnvm/pblk-recovery.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
index 0fbd30e0a587..416d9840544b 100644
--- a/drivers/lightnvm/pblk-recovery.c
+++ b/drivers/lightnvm/pblk-recovery.c
@@ -805,7 +805,6 @@ struct pblk_line *pblk_recov_l2p(struct pblk *pblk)
WARN_ON_ONCE(!test_and_clear_bit(meta_line,
&l_mg->meta_bitmap));
spin_unlock(&l_mg->free_lock);
- pblk_line_replace_data(pblk);
} else {
spin_lock(&l_mg->free_lock);
/* Allocate next line for preparation */
--
2.17.1
next prev parent reply other threads:[~2018-11-06 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 13:33 [PATCH v3 0/7] PBLK Bugfixes and cleanups Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 1/7] lightnvm: pblk: fix resubmission of overwritten write err lbas Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 2/7] lightnvm: pblk: account for write error sectors in emeta Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 3/7] lightnvm: pblk: stop writes gracefully when running out of lines Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 4/7] lightnvm: pblk: set conservative threshold for user writes Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 5/7] lightnvm: pblk: remove unused macro Hans Holmberg
2018-11-06 13:33 ` [PATCH v3 6/7] lightnvm: pblk: fix pblk_lines_init error handling path Hans Holmberg
2018-11-06 13:33 ` Hans Holmberg [this message]
2018-11-07 8:47 ` [PATCH v3 0/7] PBLK Bugfixes and cleanups Matias Bjørling
2018-11-09 9:08 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106133330.26570-8-hans.ml.holmberg@owltronix.com \
--to=hans.ml.holmberg@owltronix.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=sboisvert@gydle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).