From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0F9FC32789 for ; Tue, 6 Nov 2018 16:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C52620862 for ; Tue, 6 Nov 2018 16:01:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C52620862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389097AbeKGB0z (ORCPT ); Tue, 6 Nov 2018 20:26:55 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:41150 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388863AbeKGB0y (ORCPT ); Tue, 6 Nov 2018 20:26:54 -0500 Received: by mail-qt1-f195.google.com with SMTP id d18so3143865qto.8 for ; Tue, 06 Nov 2018 08:01:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=v99UmyEJ9iY8l2W+ohaq1eaQCnkmDJAf1xrYJELAC2g=; b=m82nVggM7DCwPysUj97h9Z9wppLLVl/5BvwK5Bek/o8WI6C901LDpa1ZOSTn5TOOkc urN8hsUjRrUhAQIL3sNOR2RNdtkWBuN0BCiqt+GSIrspyPo7qHy+/Nf6RctajmI8sT/B JTaLGYUMDko+t4Dwt2+iX10doU742p81jmkvLNkvzEHtxltiCpvZfeteTDs0Fd9SFV9P FOK8F2NLKfSPwePTGifftTw4zcdXKvBMIpIoQeRB7dF3QWbI/KLs5gCBOk4LeXMYGVS2 UDDMmYQCwYKQ3TaJ2/G0vR91tG15hj+4RWBH9FQklcK4CwiHwlPSyFyoXBebG6WGwtHK noXQ== X-Gm-Message-State: AGRZ1gLmSC2F+q777vKD19uTIKWzju/A6EvwAxVVnca0s1ucv7487eM6 ceNRAlBT9uMU0v6qiwUbshwCmg== X-Google-Smtp-Source: AJdET5cTv5nFSLT1BO4z1e8fqZvq+cOisGf6lY7vsnPrpjxI1GXI1rcDtbH7mBce2RofCV1hn56DSA== X-Received: by 2002:aed:2d86:: with SMTP id i6mr2339898qtd.227.1541520061178; Tue, 06 Nov 2018 08:01:01 -0800 (PST) Received: from localhost (ip72-223-3-97.ph.ph.cox.net. [72.223.3.97]) by smtp.gmail.com with ESMTPSA id b17sm10969455qkj.69.2018.11.06.08.01.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Nov 2018 08:01:00 -0800 (PST) Date: Tue, 6 Nov 2018 09:00:58 -0700 From: Jerry Snitselaar To: Stefan Berger , keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, zohar@linux.ibm.com, jejb@linux.ibm.com, Alexander.Levin@microsoft.com, jmorris@namei.org, linux-kernel@vger.kernel.org Cc: William Roberts Subject: Re: [PATCH] docs: Extend trusted keys documentation for TPM 2.0 Message-ID: <20181106160058.5ov7yhzq6mbrg6yn@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Stefan Berger , keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, zohar@linux.ibm.com, jejb@linux.ibm.com, Alexander.Levin@microsoft.com, jmorris@namei.org, linux-kernel@vger.kernel.org, William Roberts References: <20181019101758.1569-1-stefanb@linux.ibm.com> <20181105204215.hw6vme5epxcc3nch@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181105204215.hw6vme5epxcc3nch@cantor> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon Nov 05 18, Jerry Snitselaar wrote: >On Fri Oct 19 18, Stefan Berger wrote: >>Extend the documentation for trusted keys with documentation for how to >>set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well. >> >>Signed-off-by: Stefan Berger >>Reviewed-by: Mimi Zohar >>--- >>.../security/keys/trusted-encrypted.rst | 31 ++++++++++++++++++- >>1 file changed, 30 insertions(+), 1 deletion(-) >> >>diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst >>index 3bb24e09a332..6ec6bb2ac497 100644 >>--- a/Documentation/security/keys/trusted-encrypted.rst >>+++ b/Documentation/security/keys/trusted-encrypted.rst >>@@ -18,10 +18,33 @@ integrity verifications match. A loaded Trusted Key can be updated with new >>when the kernel and initramfs are updated. The same key can have many saved >>blobs under different PCR values, so multiple boots are easily supported. >> >>+TPM 1.2 >>+------- >>+ >>By default, trusted keys are sealed under the SRK, which has the default >>authorization value (20 zeros). This can be set at takeownership time with the >>trouser's utility: "tpm_takeownership -u -z". >> >>+TPM 2.0 >>+------- >>+ >>+The user must first create a storage key and make it persistent, so the key is >>+available after reboot. This can be done using the following commands. >>+ >>+With the IBM TSS 2 stack:: >>+ >>+ #> tsscreateprimary -hi o -st >>+ Handle 80000000 >>+ #> tssevictcontrol -hi o -ho 80000000 -hp 81000001 >>+ >>+Or with the Intel TSS 2 stack:: >>+ >>+ #> tpm2_createprimary --hierarchy o -G rsa2048 -o key.ctxt >>+ [...] >>+ handle: 0x800000FF >>+ #> tpm2_evictcontrol -c key.ctxt -p 0x81000001 >>+ persistentHandle: 0x81000001 >>+ > >Is that the correct option for tpm2_evictcontrol? What I'm seeing >in the versions I have is -S or -persistent= for specifying the persistent handle. > >Other than that looks good to me. William, is the above correct? > >>Usage:: >> >> keyctl add trusted name "new keylen [options]" ring >>@@ -30,7 +53,9 @@ Usage:: >> keyctl print keyid >> >> options: >>- keyhandle= ascii hex value of sealing key default 0x40000000 (SRK) >>+ keyhandle= ascii hex value of sealing key >>+ TPM 1.2: default 0x40000000 (SRK) >>+ TPM 2.0: no default; must be passed every time >> keyauth= ascii hex auth for sealing key default 0x00...i >> (40 ascii zeros) >> blobauth= ascii hex auth for sealed data default 0x00... >>@@ -84,6 +109,10 @@ Examples of trusted and encrypted key usage: >> >>Create and save a trusted key named "kmk" of length 32 bytes:: >> >>+Note: When using a TPM 2.0 with a persistent key with handle 0x81000001, >>+append 'keyhandle=0x81000001' to statements between quotes, such as >>+"new 32 keyhandle=0x81000001". >>+ >> $ keyctl add trusted kmk "new 32" @u >> 440502848 >> >>-- >>2.17.2 >>