From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Lubomir Rintel <lkundrak@v3.sk>
Cc: kbuild-all@01.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>, James Cameron <quozl@laptop.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 11/11] [media] marvell-ccic: provide a clock for the sensor
Date: Wed, 7 Nov 2018 07:42:15 +0300 [thread overview]
Message-ID: <20181107044146.d5lsvtyjeit7goas@mwanda> (raw)
In-Reply-To: <20181105073054.24407-12-lkundrak@v3.sk>
Hi Lubomir,
url: https://github.com/0day-ci/linux/commits/Lubomir-Rintel/media-ov7670-hook-s_power-onto-v4l2-core/20181105-163336
base: git://linuxtv.org/media_tree.git master
smatch warnings:
drivers/media/platform/marvell-ccic/mcam-core.c:1682 mcam_v4l_open() warn: inconsistent returns 'mutex:&cam->s_mutex'.
Locked on: line 1673
Unlocked on: line 1682
# https://github.com/0day-ci/linux/commit/a4f7d692c7067355da433bbb534531a4e1a55ac6
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout a4f7d692c7067355da433bbb534531a4e1a55ac6
vim +1682 drivers/media/platform/marvell-ccic/mcam-core.c
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1656
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1657 /* ---------------------------------------------------------------------- */
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1658 /*
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1659 * Our various file operations.
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1660 */
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1661 static int mcam_v4l_open(struct file *filp)
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1662 {
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1663 struct mcam_camera *cam = video_drvdata(filp);
949bd408 drivers/media/platform/marvell-ccic/mcam-core.c Hans Verkuil 2015-03-05 1664 int ret;
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1665
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1666 mutex_lock(&cam->s_mutex);
949bd408 drivers/media/platform/marvell-ccic/mcam-core.c Hans Verkuil 2015-03-05 1667 ret = v4l2_fh_open(filp);
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1668 if (ret)
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1669 goto out;
949bd408 drivers/media/platform/marvell-ccic/mcam-core.c Hans Verkuil 2015-03-05 1670 if (v4l2_fh_is_singular_file(filp)) {
a4f7d692 drivers/media/platform/marvell-ccic/mcam-core.c Lubomir Rintel 2018-11-05 1671 ret = sensor_call(cam, core, s_power, 1);
05fed816 drivers/media/platform/marvell-ccic/mcam-core.c Libin Yang 2013-07-03 1672 if (ret)
a4f7d692 drivers/media/platform/marvell-ccic/mcam-core.c Lubomir Rintel 2018-11-05 1673 return ret;
^^^^^^^^^^
This should be a goto out;
a4f7d692 drivers/media/platform/marvell-ccic/mcam-core.c Lubomir Rintel 2018-11-05 1674 mcam_clk_enable(cam);
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1675 __mcam_cam_reset(cam);
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1676 mcam_set_config_needed(cam, 1);
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1677 }
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1678 out:
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 1679 mutex_unlock(&cam->s_mutex);
44fbcb10 drivers/media/platform/marvell-ccic/mcam-core.c Hans Verkuil 2015-03-05 1680 if (ret)
44fbcb10 drivers/media/platform/marvell-ccic/mcam-core.c Hans Verkuil 2015-03-05 1681 v4l2_fh_release(filp);
d43dae75 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-07-08 @1682 return ret;
a9b36e85 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-20 1683 }
abfa3df3 drivers/media/video/marvell-ccic/mcam-core.c Jonathan Corbet 2011-06-11 1684
:::::: The code at line 1682 was first introduced by commit
:::::: d43dae75cc1140bf27a59aa6d8e8bc7a00f009cc [media] marvell-cam: core code reorganization
:::::: TO: Jonathan Corbet <corbet@lwn.net>
:::::: CC: Mauro Carvalho Chehab <mchehab@redhat.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2018-11-07 4:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 7:30 [PATCH 0/11] media: make Marvell camera work on DT-based OLPC XO-1.75 Lubomir Rintel
2018-11-05 7:30 ` [PATCH 01/11] media: ov7670: hook s_power onto v4l2 core Lubomir Rintel
2018-11-05 7:30 ` [PATCH 02/11] media: ov7670: control clock along with power Lubomir Rintel
2018-11-05 7:30 ` [PATCH 03/11] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera Lubomir Rintel
2018-11-05 7:30 ` [PATCH 04/11] [media] marvell-ccic: fix DMA s/g desc number calculation Lubomir Rintel
2018-11-05 7:30 ` [PATCH 05/11] [media] marvell-ccic: don't generate EOF on parallel bus Lubomir Rintel
2018-11-05 9:07 ` Pavel Machek
2018-11-05 7:30 ` [PATCH 06/11] [media] marvell-ccic: drop ctlr_reset() Lubomir Rintel
2018-11-05 9:11 ` Pavel Machek
2018-11-05 7:30 ` [PATCH 07/11] [media] marvell-ccic: drop unused stuff Lubomir Rintel
2018-11-05 9:17 ` Pavel Machek
2018-11-05 7:30 ` [PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers Lubomir Rintel
2018-11-05 9:17 ` Pavel Machek
2018-11-05 7:30 ` [PATCH 09/11] [media] marvell-ccic/mmp: add devicetree support Lubomir Rintel
2018-11-05 9:20 ` Pavel Machek
2018-11-05 7:30 ` [PATCH 10/11] [media] marvell-ccic: use async notifier to get the sensor Lubomir Rintel
2018-11-05 7:30 ` [PATCH 11/11] [media] marvell-ccic: provide a clock for " Lubomir Rintel
2018-11-05 13:01 ` kbuild test robot
2018-11-07 4:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107044146.d5lsvtyjeit7goas@mwanda \
--to=dan.carpenter@oracle.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pavel@ucw.cz \
--cc=quozl@laptop.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).