From: "Clément Péron" <peron.clem@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Suji Velupillai" <suji.velupillai@broadcom.com>,
"Clément Péron" <peron.clem@gmail.com>
Subject: [PATCH 2/2] pwm: bcm-kona: apply pwm settings on enable
Date: Wed, 7 Nov 2018 10:36:13 +0100 [thread overview]
Message-ID: <20181107093613.26734-2-peron.clem@gmail.com> (raw)
In-Reply-To: <20181107093613.26734-1-peron.clem@gmail.com>
From: Suji Velupillai <suji.velupillai@broadcom.com>
When pwm_bl framework calls enable, a call to pwm_is_enabled(pwm) still
return false, this prevents the backlight being turn on at boot time.
Signed-off-by: Suji Velupillai <suji.velupillai@broadcom.com>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
drivers/pwm/pwm-bcm-kona.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 09a95aeb3a70..d991d53c4b38 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -108,8 +108,8 @@ static void kona_pwmc_apply_settings(struct kona_pwmc *kp, unsigned int chan)
ndelay(400);
}
-static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
- int duty_ns, int period_ns)
+static int __pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
+ int duty_ns, int period_ns, bool pwmc_enabled)
{
struct kona_pwmc *kp = to_kona_pwmc(chip);
u64 val, div, rate;
@@ -155,7 +155,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
* always calculated above to ensure the new values are
* validated immediately instead of on enable.
*/
- if (pwm_is_enabled(pwm)) {
+ if (pwm_is_enabled(pwm) || pwmc_enabled) {
kona_pwmc_prepare_for_settings(kp, chan);
value = readl(kp->base + PRESCALE_OFFSET);
@@ -173,6 +173,12 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
return 0;
}
+static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
+ int duty_ns, int period_ns)
+{
+ return __pwmc_config(chip, pwm, duty_ns, period_ns, false);
+}
+
static int kona_pwmc_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
enum pwm_polarity polarity)
{
@@ -216,8 +222,8 @@ static int kona_pwmc_enable(struct pwm_chip *chip, struct pwm_device *pwm)
return ret;
}
- ret = kona_pwmc_config(chip, pwm, pwm_get_duty_cycle(pwm),
- pwm_get_period(pwm));
+ ret = __pwmc_config(chip, pwm, pwm_get_duty_cycle(pwm),
+ pwm_get_period(pwm), true);
if (ret < 0) {
clk_disable_unprepare(kp->clk);
return ret;
--
2.19.1
next prev parent reply other threads:[~2018-11-07 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 9:36 [PATCH 1/2] pwm: kconfig: enable kona pwm to be built for cygnus arch Clément Péron
2018-11-07 9:36 ` Clément Péron [this message]
2018-11-07 16:29 ` [PATCH 2/2] pwm: bcm-kona: apply pwm settings on enable Uwe Kleine-König
2018-11-08 10:47 ` Clément Péron
2018-11-08 10:59 ` Uwe Kleine-König
2018-11-08 15:32 ` Tim Kryger
2018-12-12 11:04 ` Thierry Reding
2018-12-12 11:07 ` Clément Péron
2018-11-07 16:12 ` [PATCH 1/2] pwm: kconfig: enable kona pwm to be built for cygnus arch Uwe Kleine-König
2018-11-07 16:48 ` Scott Branden
2018-11-08 10:47 ` Clément Péron
2018-11-08 12:22 ` Thierry Reding
2018-11-09 9:58 ` Clément Péron
2018-11-09 10:53 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107093613.26734-2-peron.clem@gmail.com \
--to=peron.clem@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=suji.velupillai@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).