From: Darren Hart <dvhart@infradead.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] scripts/kconfig/merge_config: don't redefine 'y' to 'm'
Date: Wed, 7 Nov 2018 10:47:05 -0800 [thread overview]
Message-ID: <20181107184705.GA95239@fedora.eng.vmware.com> (raw)
In-Reply-To: <CADYN=9L2kEVJMiVRBUBU7z4B4_YrvkNefCE5FO3qjACgm=FugA@mail.gmail.com>
On Tue, Nov 06, 2018 at 02:57:40PM +0100, Anders Roxell wrote:
> On Mon, 5 Nov 2018 at 09:35, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > Hi Anders,
> >
> > On Fri, Nov 2, 2018 at 8:41 PM Anders Roxell <anders.roxell@linaro.org> wrote:
> > >
> > > In today's merge_config.sh the order of the config fragment files dictates
> > > the output of a config option. With this approach we will get different
> > > .config files depending on the order of the config fragment files.
> > > Adding a switch to add precedence for builtin over modules, this will
> > > make the .config file the same
> > >
> > > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > ---
> >
> > I think this patch makes sense.
> >
> > Just in case, could you please provide me the context of the discussion?
>
> For instance we don't want to force X86 from DRM=y to DRM=m, when
> enabling selftest, that would surely break somebody's setup and you also
> don't want to force ARM64 from DRM=m to DRM=y, that seems
> unnecessary for a big subsystem like DRM.
>
> >
> > Does the real problem exist in the kernel tree,
>
> Not that I'm aware about.
>
> Cheers,
> Anders
>
> > or for local fragment files?
This is really about ordering of fragment files and not "making a symbol
'less'", I think were Arnd's words.
So, doing something like:
$ make arm64-selftest.config drm.config
where arm64-selftest.config defines DRM=y and drm.config defines DRM=m, the
result should be "DRM=y".
So the first step is to make merge_config.sh support it. A follow up step would
be to integrate this into the kernel Makefile system if we determine this is the
correct behavior, or to provide a parameter if we don't want to change the
default behavior.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-11-07 18:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:41 [PATCH] scripts/kconfig/merge_config: don't redefine 'y' to 'm' Anders Roxell
2018-11-05 8:34 ` Masahiro Yamada
2018-11-06 13:57 ` Anders Roxell
2018-11-07 18:47 ` Darren Hart [this message]
2018-11-07 19:36 ` Darren Hart
2018-11-08 19:43 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107184705.GA95239@fedora.eng.vmware.com \
--to=dvhart@infradead.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).