From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/char/random.c: make primary_crng static
Date: Wed, 7 Nov 2018 17:11:48 -0500 [thread overview]
Message-ID: <20181107221148.GC17171@thunk.org> (raw)
In-Reply-To: <20181102110447.23121-3-linux@rasmusvillemoes.dk>
On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote:
> Since the definition of struct crng_state is private to random.c, and
> primary_crng is neither declared or used elsewhere, there's no reason
> for that symbol to have external linkage.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2018-11-07 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 11:04 [PATCH 1/3] drivers/char/random.c: constify poolinfo_table Rasmus Villemoes
2018-11-02 11:04 ` [PATCH 2/3] drivers/char/random.c: remove unused stuct poolinfo::poolbits Rasmus Villemoes
2018-11-07 22:11 ` Theodore Y. Ts'o
2018-11-02 11:04 ` [PATCH 3/3] drivers/char/random.c: make primary_crng static Rasmus Villemoes
2018-11-07 22:11 ` Theodore Y. Ts'o [this message]
2018-11-07 22:11 ` [PATCH 1/3] drivers/char/random.c: constify poolinfo_table Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107221148.GC17171@thunk.org \
--to=tytso@mit.edu \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).