From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Quentin Schulz <quentin.schulz@bootlin.com>,
Manu Gautam <mgautam@codeaurora.org>,
Tony Lindgren <tony@atomide.com>,
netdev@vger.kernel.org,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
linux-mediatek@lists.infradead.org,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/5] phy: core: add PHY_MODE_ETHERNET
Date: Thu, 8 Nov 2018 00:42:00 +0000 [thread overview]
Message-ID: <20181108004200.GW30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181108003617.10334-3-grygorii.strashko@ti.com>
On Wed, Nov 07, 2018 at 06:36:14PM -0600, Grygorii Strashko wrote:
> Add new PHY's mode to be used by Ethernet PHY interface drivers or
> multipurpose PHYs like serdes. It will be reused in further changes.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> include/linux/phy/phy.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index b17e770..02c9ef0 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -42,6 +42,7 @@ enum phy_mode {
> PHY_MODE_UFS_HS_A,
> PHY_MODE_UFS_HS_B,
> PHY_MODE_PCIE,
> + PHY_MODE_ETHERNET,
Are you sure about this - we already have a bunch of "ethernet" modes
that are more specific, like PHY_MODE_SGMII, PHY_MODE_2500SGMII and
PHY_MODE_10GKR which require PHYs to be configured differently. Having
a very generic "ethernet" mode brings up questions about when it should
be used vs the more specific modes.
(I've already mentioned that the SGMII modes are mis-named, since
they also apply to 1000base-X and 2500base-X - the only difference
is how one 16-bit word in the data stream is used which has no effect
on the PHY.)
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2018-11-08 0:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 0:36 [PATCH 0/5] hy: core: rework phy_set_mode to accept phy mode and submode Grygorii Strashko
2018-11-08 0:36 ` [PATCH 1/5] phy: " Grygorii Strashko
2018-11-08 0:36 ` [PATCH 2/5] phy: core: add PHY_MODE_ETHERNET Grygorii Strashko
2018-11-08 0:42 ` Russell King - ARM Linux [this message]
2018-11-08 18:12 ` Grygorii Strashko
2018-11-08 0:36 ` [PATCH 3/5] phy: ocelot-serdes: convert to use eth phy mode and submode Grygorii Strashko
2018-11-08 0:36 ` [PATCH 4/5] phy: mvebu-cp110-comphy: " Grygorii Strashko
2018-11-08 22:21 ` Russell King - ARM Linux
2018-11-08 22:42 ` Grygorii Strashko
2018-11-16 16:05 ` Maxime Chevallier
2018-11-08 0:36 ` [PATCH 5/5] phy: core: clean up unused ethernet specific phy modes Grygorii Strashko
2018-11-09 3:20 ` [PATCH 0/5] hy: core: rework phy_set_mode to accept phy mode and submode David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108004200.GW30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.belloni@bootlin.com \
--cc=antoine.tenart@free-electrons.com \
--cc=carlo@caione.org \
--cc=chunfeng.yun@mediatek.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=mgautam@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=quentin.schulz@bootlin.com \
--cc=tony@atomide.com \
--cc=vivek.gautam@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).