From: Viresh Kumar <viresh.kumar@linaro.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: kgene@kernel.org, krzk@kernel.org, rjw@rjwysocki.net,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: s3c24xx: Change to use DEFINE_SHOW_ATTRIBUTE macro
Date: Thu, 8 Nov 2018 10:15:03 +0530 [thread overview]
Message-ID: <20181108044503.7zqgi3cjsxnsziuo@vireshk-i7> (raw)
In-Reply-To: <20181107161346.9887-1-tiny.windzz@gmail.com>
On 07-11-18, 11:13, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpufreq/s3c24xx-cpufreq-debugfs.c | 46 +++--------------------
> 1 file changed, 6 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c b/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
> index 4d976e8dbb2f..0df87b6480fe 100644
> --- a/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
> +++ b/drivers/cpufreq/s3c24xx-cpufreq-debugfs.c
> @@ -63,18 +63,7 @@ static int board_show(struct seq_file *seq, void *p)
> return 0;
> }
>
> -static int fops_board_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, board_show, NULL);
> -}
> -
> -static const struct file_operations fops_board = {
> - .open = fops_board_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> - .owner = THIS_MODULE,
> -};
> +DEFINE_SHOW_ATTRIBUTE(board);
>
> static int info_show(struct seq_file *seq, void *p)
> {
> @@ -105,18 +94,7 @@ static int info_show(struct seq_file *seq, void *p)
> return 0;
> }
>
> -static int fops_info_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, info_show, NULL);
> -}
> -
> -static const struct file_operations fops_info = {
> - .open = fops_info_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> - .owner = THIS_MODULE,
> -};
> +DEFINE_SHOW_ATTRIBUTE(info);
>
> static int io_show(struct seq_file *seq, void *p)
> {
> @@ -162,19 +140,7 @@ static int io_show(struct seq_file *seq, void *p)
> return 0;
> }
>
> -static int fops_io_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, io_show, NULL);
> -}
> -
> -static const struct file_operations fops_io = {
> - .open = fops_io_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> - .owner = THIS_MODULE,
> -};
> -
> +DEFINE_SHOW_ATTRIBUTE(io);
>
> static int __init s3c_freq_debugfs_init(void)
> {
> @@ -185,13 +151,13 @@ static int __init s3c_freq_debugfs_init(void)
> }
>
> dbgfs_file_io = debugfs_create_file("io-timing", S_IRUGO, dbgfs_root,
> - NULL, &fops_io);
> + NULL, &io_fops);
>
> dbgfs_file_info = debugfs_create_file("info", S_IRUGO, dbgfs_root,
> - NULL, &fops_info);
> + NULL, &info_fops);
>
> dbgfs_file_board = debugfs_create_file("board", S_IRUGO, dbgfs_root,
> - NULL, &fops_board);
> + NULL, &board_fops);
>
> return 0;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2018-11-08 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 16:13 [PATCH] cpufreq: s3c24xx: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-11-08 4:45 ` Viresh Kumar [this message]
2018-12-11 10:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108044503.7zqgi3cjsxnsziuo@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).